[GitHub] [tvm] Lunderberg opened a new pull request, #14494: [TIR] Use IRModuleNode::Remove to remove None in PrimFuncPass

["Lunderberg (via GitHub)" <gi...@apache.org>]

Lunderberg opened a new pull request, #14494:
URL: https://github.com/apache/tvm/pull/14494

   Prior to this commit, `PrimFuncPass` directly removed empty `PrimFunc` objects from the module's `Map<GlobalVar, BaseFunc> functions`. Because it didn't update the `global_var_map_` as well, these two maps could become out of sync.  Since the `global_var_map_` is checked as part of `StructuralEqual()`, but isn't displayed when printing to TVMScript, this can result in identical printouts being flagged as non-identical.
   
   This commit updates `PrimFuncPass` to call the `IRModuleNode::Remove` method, which updates both the `functions` and `global_var_map_` variables.
   
   This is part of changes described in https://github.com/apache/tvm/pull/14486, to improve round-trip failures that occur in lowering.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #14494: [TIR] Use IRModuleNode::Remove to remove None in PrimFuncPass

["tvm-bot (via GitHub)" <gi...@apache.org>]

tvm-bot commented on PR #14494:
URL: https://github.com/apache/tvm/pull/14494#issuecomment-1496262581

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @Hzfengsy, @junrushao, @quic-sanirudh, @shingjan <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen merged pull request #14494: [TIR] Use IRModuleNode::Remove to remove None in PrimFuncPass

["tqchen (via GitHub)" <gi...@apache.org>]

tqchen merged PR #14494:
URL: https://github.com/apache/tvm/pull/14494


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org