You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/01/09 20:04:59 UTC

[GitHub] [orc] dongjoon-hyun commented on pull request #614: ORC-719: Enable UnusedImports rule.

dongjoon-hyun commented on pull request #614:
URL: https://github.com/apache/orc/pull/614#issuecomment-757360005


   To @williamhyun and reviewers, I verified this PR manually like the following by adding an example.
   ```
   $ git diff
   diff --git a/java/core/src/java/org/apache/orc/impl/AircompressorCodec.java b/java/core/src/java/org/apache/orc/impl/AircompressorCodec.java
   index 3793cba4..6110858b 100644
   --- a/java/core/src/java/org/apache/orc/impl/AircompressorCodec.java
   +++ b/java/core/src/java/org/apache/orc/impl/AircompressorCodec.java
   @@ -23,6 +23,7 @@ import io.airlift.compress.Decompressor;
    import org.apache.orc.CompressionCodec;
    import org.apache.orc.CompressionKind;
   
   +import java.io.File;
    import java.io.IOException;
    import java.nio.ByteBuffer;
   ```
   
   ```
   $ mvn checkstyle:check | grep ERROR
   Using `mvn` from path: /usr/local/bin/mvn
   [ERROR] src/java/org/apache/orc/impl/AircompressorCodec.java:[26,8] (imports) UnusedImports: Unused import - java.io.File.
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org