Re: [PR] [SPARK-43035][Connect] Add error class in Spark Connect server's ErrorInfo [spark]

["MaxGekk (via GitHub)" <gi...@apache.org>]

MaxGekk commented on code in PR #42053:
URL: https://github.com/apache/spark/pull/42053#discussion_r1360746508


##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectServer.scala:
##########
@@ -43,7 +43,15 @@ object SparkConnectServer extends Logging {
         }
       } catch {
         case e: Exception =>
-          logError("Error starting Spark Connect server", e)
+          e.getCause match {
+            case sparkThrowable: SparkThrowable if (sparkThrowable.getErrorClass != null) =>

Review Comment:
   Can you add a test for the case?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org