You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Ignite TC Bot (Jira)" <ji...@apache.org> on 2020/07/24 15:32:00 UTC
[jira] [Commented] (IGNITE-13291) Remove unnecessary dependency to
curator-client from ZookeeperDiscoverySpi
[ https://issues.apache.org/jira/browse/IGNITE-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164494#comment-17164494 ]
Ignite TC Bot commented on IGNITE-13291:
----------------------------------------
{panel:title=Branch: [pull/8080/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/8080/head] Base: [master] : New Tests (16)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#00008b}ZooKeeper (Discovery) 1{color} [[tests 8|https://ci.ignite.apache.org/viewLog.html?buildId=5488110]]
* {color:#013220}ZookeeperDiscoverySpiTestSuite1: ZookeeperValidatePathsTest$ZoookeperCommonValidatePathsTest.testValidatePath[input string = /apacheIgnite/./root, expected error = relative paths not allowed @14] - PASSED{color}
* {color:#013220}ZookeeperDiscoverySpiTestSuite1: ZookeeperValidatePathsTest$ZoookeperCommonValidatePathsTest.testValidatePath[input string = /apacheIgnite/../root, expected error = relative paths not allowed @15] - PASSED{color}
* {color:#013220}ZookeeperDiscoverySpiTestSuite1: ZookeeperValidatePathsTest$ZoookeperCommonValidatePathsTest.testValidatePath[input string = , expected error = Path length must be > 0] - PASSED{color}
* {color:#013220}ZookeeperDiscoverySpiTestSuite1: ZookeeperValidatePathsTest$ZoookeperCommonValidatePathsTest.testValidatePath[input string = null, expected error = Path cannot be null] - PASSED{color}
* {color:#013220}ZookeeperDiscoverySpiTestSuite1: ZookeeperValidatePathsTest$ZoookeperCommonValidatePathsTest.testValidatePath[input string = /apacheIgnite, expected error = null] - PASSED{color}
* {color:#013220}ZookeeperDiscoverySpiTestSuite1: ZookeeperValidatePathsTest$ZookeeperUnprintableCharactersValidatePathTest.testValidatePathWithUnprintableCharacters - PASSED{color}
* {color:#013220}ZookeeperDiscoverySpiTestSuite1: ZookeeperValidatePathsTest$ZoookeperCommonValidatePathsTest.testValidatePath[input string = /apacheIgnite/, expected error = Path must not end with / character] - PASSED{color}
* {color:#013220}ZookeeperDiscoverySpiTestSuite1: ZookeeperValidatePathsTest$ZoookeperCommonValidatePathsTest.testValidatePath[input string = /apacheIgnite//root, expected error = empty node name specified @14] - PASSED{color}
{color:#00008b}Service Grid{color} [[tests 4|https://ci.ignite.apache.org/viewLog.html?buildId=5487964]]
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple [val1=DiscoveryEvent [evtNode=d7d462f4-63bc-48a1-bd69-f5599238f3c6, topVer=0, msgTemplate=null, span=null, nodeId8=1c82fb8a, msg=, type=NODE_JOINED, tstamp=1595590130398], val2=AffinityTopologyVersion [topVer=-8269426557086687585, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple [val1=DiscoveryEvent [evtNode=d7d462f4-63bc-48a1-bd69-f5599238f3c6, topVer=0, msgTemplate=null, span=null, nodeId8=1c82fb8a, msg=, type=NODE_JOINED, tstamp=1595590130398], val2=AffinityTopologyVersion [topVer=-8269426557086687585, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple [val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest [id=f972f908371-d920e840-65d0-4173-9357-5b636c63ddf5, reqs=SingletonList [ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent [evtNode=c2be829a-4238-49ee-99ec-367ba4d3e9ad, topVer=0, msgTemplate=null, span=null, nodeId8=c2be829a, msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1595590130398]], val2=AffinityTopologyVersion [topVer=-1159666316104886390, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple [val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest [id=f972f908371-d920e840-65d0-4173-9357-5b636c63ddf5, reqs=SingletonList [ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent [evtNode=c2be829a-4238-49ee-99ec-367ba4d3e9ad, topVer=0, msgTemplate=null, span=null, nodeId8=c2be829a, msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1595590130398]], val2=AffinityTopologyVersion [topVer=-1159666316104886390, minorTopVer=0]]] - PASSED{color}
{color:#00008b}Service Grid (legacy mode){color} [[tests 4|https://ci.ignite.apache.org/viewLog.html?buildId=5487965]]
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple [val1=DiscoveryEvent [evtNode=7276804f-39be-4a6e-8b48-7bf276229151, topVer=0, msgTemplate=null, span=null, nodeId8=fec4c1da, msg=, type=NODE_JOINED, tstamp=1595589896490], val2=AffinityTopologyVersion [topVer=5196619265185798363, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple [val1=DiscoveryEvent [evtNode=7276804f-39be-4a6e-8b48-7bf276229151, topVer=0, msgTemplate=null, span=null, nodeId8=fec4c1da, msg=, type=NODE_JOINED, tstamp=1595589896490], val2=AffinityTopologyVersion [topVer=5196619265185798363, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple [val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest [id=ad97b908371-afe02d4b-55ea-48c2-9e29-1f301750e9e9, reqs=SingletonList [ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent [evtNode=e241ffd5-307a-423e-905a-3a13b08a3607, topVer=0, msgTemplate=null, span=null, nodeId8=e241ffd5, msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1595589896490]], val2=AffinityTopologyVersion [topVer=-2879404060468761908, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple [val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest [id=ad97b908371-afe02d4b-55ea-48c2-9e29-1f301750e9e9, reqs=SingletonList [ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent [evtNode=e241ffd5-307a-423e-905a-3a13b08a3607, topVer=0, msgTemplate=null, span=null, nodeId8=e241ffd5, msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1595589896490]], val2=AffinityTopologyVersion [topVer=-2879404060468761908, minorTopVer=0]]] - PASSED{color}
{panel}
[TeamCity *--> Run :: All* Results|https://ci.ignite.apache.org/viewLog.html?buildId=5487987&buildTypeId=IgniteTests24Java8_RunAll]
> Remove unnecessary dependency to curator-client from ZookeeperDiscoverySpi
> --------------------------------------------------------------------------
>
> Key: IGNITE-13291
> URL: https://issues.apache.org/jira/browse/IGNITE-13291
> Project: Ignite
> Issue Type: Improvement
> Components: zookeeper
> Affects Versions: 2.9
> Reporter: Ivan Daschinskiy
> Assignee: Ivan Daschinskiy
> Priority: Trivial
> Fix For: 2.10
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, I suppose by mistake, we use
> {{org.apache.curator.utils.PathUtils#validatePath(java.lang.String)}} from {{curator-client}}
> in {{ZookeeperDiscoverySpi}}. Generally, this discovery implementation doesn't depend on curator framework at all, except some test code. We should remove this dependency and add this utility method to our codebase.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)