You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jeremy Hanna (JIRA)" <ji...@apache.org> on 2010/08/24 18:29:16 UTC
[jira] Created: (CASSANDRA-1425) get input splits thrift method
still takes a KS as an arg
get input splits thrift method still takes a KS as an arg
---------------------------------------------------------
Key: CASSANDRA-1425
URL: https://issues.apache.org/jira/browse/CASSANDRA-1425
Project: Cassandra
Issue Type: Task
Components: Core
Affects Versions: 0.7 beta 1
Reporter: Jeremy Hanna
Priority: Minor
Fix For: 0.7 beta 2
the get input splits method still takes a keyspace as an arg. it shouldn't need to and iirc, there should be a keySpace var in that class so that method could just use keySpace.getString(). I just didn't have a chance to test it out and I didn't want it to slip through the cracks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1425) get input splits thrift method
still takes a KS as an arg
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907077#action_12907077 ]
Jonathan Ellis commented on CASSANDRA-1425:
-------------------------------------------
can you summarize "non api changes"?
> get input splits thrift method still takes a KS as an arg
> ---------------------------------------------------------
>
> Key: CASSANDRA-1425
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1425
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jeremy Hanna
> Assignee: Jeremy Hanna
> Priority: Minor
> Fix For: 0.7 beta 2
>
> Attachments: 0001-1425-non-api-changes.patch, 0002-1425-api-changes.patch
>
>
> the get input splits method still takes a keyspace as an arg. it shouldn't need to and iirc, there should be a keySpace var in that class so that method could just use keySpace.getString(). I just didn't have a chance to test it out and I didn't want it to slip through the cracks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1425) get input splits thrift method
still takes a KS as an arg
Posted by "Jeremy Hanna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907079#action_12907079 ]
Jeremy Hanna commented on CASSANDRA-1425:
-----------------------------------------
non-api just meant non-interface/generated code. it's removing the keyspace arg and using set_keyspace for the keyspace state on the clientState.
> get input splits thrift method still takes a KS as an arg
> ---------------------------------------------------------
>
> Key: CASSANDRA-1425
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1425
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jeremy Hanna
> Assignee: Jeremy Hanna
> Priority: Minor
> Fix For: 0.7 beta 2
>
> Attachments: 0001-1425-non-api-changes.patch, 0002-1425-api-changes.patch
>
>
> the get input splits method still takes a keyspace as an arg. it shouldn't need to and iirc, there should be a keySpace var in that class so that method could just use keySpace.getString(). I just didn't have a chance to test it out and I didn't want it to slip through the cracks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1425) get input splits thrift method
still takes a KS as an arg
Posted by "Jeremy Hanna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Hanna updated CASSANDRA-1425:
------------------------------------
Attachment: 0001-1425-non-api-changes.patch
0002-1425-api-changes.patch
Adding patches to remove keyspace argument from describe_splits.
> get input splits thrift method still takes a KS as an arg
> ---------------------------------------------------------
>
> Key: CASSANDRA-1425
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1425
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jeremy Hanna
> Assignee: Jeremy Hanna
> Priority: Minor
> Fix For: 0.7 beta 2
>
> Attachments: 0001-1425-non-api-changes.patch, 0002-1425-api-changes.patch
>
>
> the get input splits method still takes a keyspace as an arg. it shouldn't need to and iirc, there should be a keySpace var in that class so that method could just use keySpace.getString(). I just didn't have a chance to test it out and I didn't want it to slip through the cracks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1425) get input splits thrift method
still takes a KS as an arg
Posted by "Jeremy Hanna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901958#action_12901958 ]
Jeremy Hanna commented on CASSANDRA-1425:
-----------------------------------------
The class I mean is thrift.CassandraServer, btw.
> get input splits thrift method still takes a KS as an arg
> ---------------------------------------------------------
>
> Key: CASSANDRA-1425
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1425
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jeremy Hanna
> Priority: Minor
> Fix For: 0.7 beta 2
>
>
> the get input splits method still takes a keyspace as an arg. it shouldn't need to and iirc, there should be a keySpace var in that class so that method could just use keySpace.getString(). I just didn't have a chance to test it out and I didn't want it to slip through the cracks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1425) get input splits thrift method
still takes a KS as an arg
Posted by "Jeremy Hanna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907074#action_12907074 ]
Jeremy Hanna commented on CASSANDRA-1425:
-----------------------------------------
The issue with convertToThrift affects the contrib/word_count execution - server throws an NPE in ColumnFamilyRecordReader.
> get input splits thrift method still takes a KS as an arg
> ---------------------------------------------------------
>
> Key: CASSANDRA-1425
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1425
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jeremy Hanna
> Assignee: Jeremy Hanna
> Priority: Minor
> Fix For: 0.7 beta 2
>
> Attachments: 0001-1425-non-api-changes.patch, 0002-1425-api-changes.patch
>
>
> the get input splits method still takes a keyspace as an arg. it shouldn't need to and iirc, there should be a keySpace var in that class so that method could just use keySpace.getString(). I just didn't have a chance to test it out and I didn't want it to slip through the cracks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1425) get input splits thrift method
still takes a KS as an arg
Posted by "Jeremy Hanna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907073#action_12907073 ]
Jeremy Hanna commented on CASSANDRA-1425:
-----------------------------------------
There is still an issue with CFMetaData from CASSANDRA-891 - convertToThrift now defaults values like subcomparator_type to empty string instead of null. So in ColumnFamilyRecordReader, it checks for null for that, but needs to take into account empty string. From a discussion in IRC, Jonathan said it would probably be easier to make it default to null again. Will be a separate ticket.
> get input splits thrift method still takes a KS as an arg
> ---------------------------------------------------------
>
> Key: CASSANDRA-1425
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1425
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jeremy Hanna
> Assignee: Jeremy Hanna
> Priority: Minor
> Fix For: 0.7 beta 2
>
> Attachments: 0001-1425-non-api-changes.patch, 0002-1425-api-changes.patch
>
>
> the get input splits method still takes a keyspace as an arg. it shouldn't need to and iirc, there should be a keySpace var in that class so that method could just use keySpace.getString(). I just didn't have a chance to test it out and I didn't want it to slip through the cracks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1425) get input splits thrift method
still takes a KS as an arg
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907239#action_12907239 ]
Jonathan Ellis commented on CASSANDRA-1425:
-------------------------------------------
describe_splits doesn't throw IRE, did you intend to add that? if not then we shouldn't be catching it
> get input splits thrift method still takes a KS as an arg
> ---------------------------------------------------------
>
> Key: CASSANDRA-1425
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1425
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jeremy Hanna
> Assignee: Jeremy Hanna
> Priority: Minor
> Fix For: 0.7 beta 2
>
> Attachments: 0001-1425-non-api-changes.patch, 0002-1425-api-changes.patch
>
>
> the get input splits method still takes a keyspace as an arg. it shouldn't need to and iirc, there should be a keySpace var in that class so that method could just use keySpace.getString(). I just didn't have a chance to test it out and I didn't want it to slip through the cracks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-1425) get input splits thrift method
still takes a KS as an arg
Posted by "Jeremy Hanna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Hanna reassigned CASSANDRA-1425:
---------------------------------------
Assignee: Jeremy Hanna
> get input splits thrift method still takes a KS as an arg
> ---------------------------------------------------------
>
> Key: CASSANDRA-1425
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1425
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jeremy Hanna
> Assignee: Jeremy Hanna
> Priority: Minor
> Fix For: 0.7 beta 2
>
>
> the get input splits method still takes a keyspace as an arg. it shouldn't need to and iirc, there should be a keySpace var in that class so that method could just use keySpace.getString(). I just didn't have a chance to test it out and I didn't want it to slip through the cracks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.