You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by TypicalGitHubUser <gi...@git.apache.org> on 2016/12/29 18:52:45 UTC
[GitHub] incubator-fineract pull request #267: Remove unnecessary checking for missin...
GitHub user TypicalGitHubUser opened a pull request:
https://github.com/apache/incubator-fineract/pull/267
Remove unnecessary checking for missing joined date.
@nazeer1100126
This change is related to pull request 1785 from openMF/community-app. I made corresponding field mandatory and checking the same on server side seems unnecessary.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TypicalGitHubUser/incubator-fineract mandatory-field-joined-date
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-fineract/pull/267.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #267
----
commit 1e437b9cc17b1c44cc12511df7c8fd6aaa1326ca
Author: Ilya Andreev <an...@gmail.com>
Date: 2016-12-29T18:46:08Z
Remove unnecessary checking for missing joined date.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #267: Remove unnecessary checking for missing joine...
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on the issue:
https://github.com/apache/incubator-fineract/pull/267
@TypicalGitHubUser goto fineract-provider directory and run `gradlew clean integrationTest` command
it will take around 30 mins to complete all integration tests. It will show an html file path about failure report. Open that and you can see which are test cases are failed. In these 20 test cases, staff is created without passing joiningDate.
Fixing these 20 test cases are not part of GCI task and ask your mentor to approve the this task (if you are a GCI student) :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #267: Remove unnecessary checking for missing joine...
Posted by TypicalGitHubUser <gi...@git.apache.org>.
Github user TypicalGitHubUser commented on the issue:
https://github.com/apache/incubator-fineract/pull/267
@nazeer1100126
> Fixing these 20 test cases are not part of GCI task and ask your mentor to approve the this task (if you are a GCI student) :-)
Yes, I will ask. Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #267: Remove unnecessary checking for missing joine...
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on the issue:
https://github.com/apache/incubator-fineract/pull/267
@TypicalGitHubUser 20 test cases are failing with this change :-).
If you have time, please correct them as it is related to joining date only. Otherwise I will fix them and merge this PR later
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #267: Remove unnecessary checking for missing joine...
Posted by TypicalGitHubUser <gi...@git.apache.org>.
Github user TypicalGitHubUser commented on the issue:
https://github.com/apache/incubator-fineract/pull/267
@nazeer1100126 Is there a description of how to run the tests? Where can I find information about the failures?
However I doubt about my ability to fix these. The change so simple that I think the tests just send empty value and expect failure. And fix should be changes in tests, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #267: Remove unnecessary checking for missin...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-fineract/pull/267
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---