You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ozone.apache.org by Stephen O'Donnell <so...@cloudera.com.INVALID> on 2020/11/12 15:46:31 UTC
[VOTE] - Merge Decommission and Maintenance (HDDS-1880)
Following on from the discussion thread, I would like to call a vote on
whether we should merge HDDS-1880 into master. This feature will enable
decommission and maintenance mode for datanodes. The feature is working,
but more work is needed to improve the usability etc. I feel the feature is
stable and self contained enough to continue that work on the master branch
now
The overall design is under HDDS-1880 and there is a summary of the
internals also attached to that Jira.
A PR for the merge is here:
https://github.com/apache/ozone/pull/1580
I will try to keep the PR up-to-date if any conflicts arise.
From the discussion thread, I can carry over 1 +1 from Marton Elek to get
us started.
As it may take some time to review the large PR I will let the vote run for
14 days, closing at midnight GMT on 26th November.
Please ask any questions here, on the PR or on ASF Slack.
Thanks,
Stephen.
Re: [VOTE] - Merge Decommission and Maintenance (HDDS-1880)
Posted by Stephen O'Donnell <so...@cloudera.com.INVALID>.
Thanks to everyone who has looked at this so far.
We have 4 +1's and my own +1 = 5.
Unless anyone objects before the vote closes on Thursday we should be good
to merge the branch on Friday of this week.
On Tue, Nov 24, 2020 at 12:48 PM Elek, Marton <el...@apache.org> wrote:
>
> Repeating my +1.
>
> 1. Deployed the branch to k8s based cluster.
> 2. Executed Spark job to generate parquet file.
> 3. Deleted / re-created one datanode
> 4. Checked the if the files are recovered after a few minutes
> 5. Executed Spark job to read (and copy) the generated parquet files
>
> Worked well.
>
> Marton
>
> ps: And thanks again to drive this Stephen. Good to see that this branch
> will be merged finally...
>
>
> On 11/12/20 4:46 PM, Stephen O'Donnell wrote:
> > Following on from the discussion thread, I would like to call a vote on
> > whether we should merge HDDS-1880 into master. This feature will enable
> > decommission and maintenance mode for datanodes. The feature is working,
> > but more work is needed to improve the usability etc. I feel the feature
> is
> > stable and self contained enough to continue that work on the master
> branch
> > now
> >
> > The overall design is under HDDS-1880 and there is a summary of the
> > internals also attached to that Jira.
> >
> > A PR for the merge is here:
> >
> > https://github.com/apache/ozone/pull/1580
> >
> > I will try to keep the PR up-to-date if any conflicts arise.
> >
> > From the discussion thread, I can carry over 1 +1 from Marton Elek to
> get
> > us started.
> >
> > As it may take some time to review the large PR I will let the vote run
> for
> > 14 days, closing at midnight GMT on 26th November.
> >
> > Please ask any questions here, on the PR or on ASF Slack.
> >
> > Thanks,
> >
> > Stephen.
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
> For additional commands, e-mail: dev-help@ozone.apache.org
>
>
Re: [VOTE] - Merge Decommission and Maintenance (HDDS-1880)
Posted by "Elek, Marton" <el...@apache.org>.
Repeating my +1.
1. Deployed the branch to k8s based cluster.
2. Executed Spark job to generate parquet file.
3. Deleted / re-created one datanode
4. Checked the if the files are recovered after a few minutes
5. Executed Spark job to read (and copy) the generated parquet files
Worked well.
Marton
ps: And thanks again to drive this Stephen. Good to see that this branch
will be merged finally...
On 11/12/20 4:46 PM, Stephen O'Donnell wrote:
> Following on from the discussion thread, I would like to call a vote on
> whether we should merge HDDS-1880 into master. This feature will enable
> decommission and maintenance mode for datanodes. The feature is working,
> but more work is needed to improve the usability etc. I feel the feature is
> stable and self contained enough to continue that work on the master branch
> now
>
> The overall design is under HDDS-1880 and there is a summary of the
> internals also attached to that Jira.
>
> A PR for the merge is here:
>
> https://github.com/apache/ozone/pull/1580
>
> I will try to keep the PR up-to-date if any conflicts arise.
>
> From the discussion thread, I can carry over 1 +1 from Marton Elek to get
> us started.
>
> As it may take some time to review the large PR I will let the vote run for
> 14 days, closing at midnight GMT on 26th November.
>
> Please ask any questions here, on the PR or on ASF Slack.
>
> Thanks,
>
> Stephen.
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
For additional commands, e-mail: dev-help@ozone.apache.org
Re: [VOTE] - Merge Decommission and Maintenance (HDDS-1880)
Posted by Shashikant Banerjee <sb...@cloudera.com.INVALID>.
+1
Thanks
Shashi
On Sun, Nov 15, 2020, 11:47 AM Lin, Yiqun <yi...@ebay.com.invalid> wrote:
> Did the general review of the PR.
>
> Also +1 to merge.
>
> Thanks,
> Yiqun
>
> From: Vivek Ratnavel <vi...@apache.org>
> Date: Friday, November 13, 2020 at 2:36 AM
> To: dev@ozone.apache.org <de...@ozone.apache.org>
> Subject: Re: [VOTE] - Merge Decommission and Maintenance (HDDS-1880)
>
> +1 to merge
>
> Thanks for working on this Stephen!
>
> On Thu, Nov 12, 2020 at 7:46 AM Stephen O'Donnell
> <so...@cloudera.com.invalid> wrote:
>
> > Following on from the discussion thread, I would like to call a vote on
> > whether we should merge HDDS-1880 into master. This feature will enable
> > decommission and maintenance mode for datanodes. The feature is working,
> > but more work is needed to improve the usability etc. I feel the feature
> is
> > stable and self contained enough to continue that work on the master
> branch
> > now
> >
> > The overall design is under HDDS-1880 and there is a summary of the
> > internals also attached to that Jira.
> >
> > A PR for the merge is here:
> >
> >
> https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fozone%2Fpull%2F1580&data=04%7C01%7Cyiqlin%40ebay.com%7C664bb86ab58e425e1ed408d88739e171%7C46326bff992841a0baca17c16c94ea99%7C0%7C1%7C637408029952904737%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=KxdTPR8jn4RbtwcHxEpbLyDsmurIbM%2FLBW1aQGAVXzY%3D&reserved=0
> >
> > I will try to keep the PR up-to-date if any conflicts arise.
> >
> > From the discussion thread, I can carry over 1 +1 from Marton Elek to get
> > us started.
> >
> > As it may take some time to review the large PR I will let the vote run
> for
> > 14 days, closing at midnight GMT on 26th November.
> >
> > Please ask any questions here, on the PR or on ASF Slack.
> >
> > Thanks,
> >
> > Stephen.
> >
>
Re: [VOTE] - Merge Decommission and Maintenance (HDDS-1880)
Posted by "Lin, Yiqun" <yi...@ebay.com.INVALID>.
Did the general review of the PR.
Also +1 to merge.
Thanks,
Yiqun
From: Vivek Ratnavel <vi...@apache.org>
Date: Friday, November 13, 2020 at 2:36 AM
To: dev@ozone.apache.org <de...@ozone.apache.org>
Subject: Re: [VOTE] - Merge Decommission and Maintenance (HDDS-1880)
+1 to merge
Thanks for working on this Stephen!
On Thu, Nov 12, 2020 at 7:46 AM Stephen O'Donnell
<so...@cloudera.com.invalid> wrote:
> Following on from the discussion thread, I would like to call a vote on
> whether we should merge HDDS-1880 into master. This feature will enable
> decommission and maintenance mode for datanodes. The feature is working,
> but more work is needed to improve the usability etc. I feel the feature is
> stable and self contained enough to continue that work on the master branch
> now
>
> The overall design is under HDDS-1880 and there is a summary of the
> internals also attached to that Jira.
>
> A PR for the merge is here:
>
> https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fozone%2Fpull%2F1580&data=04%7C01%7Cyiqlin%40ebay.com%7C664bb86ab58e425e1ed408d88739e171%7C46326bff992841a0baca17c16c94ea99%7C0%7C1%7C637408029952904737%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=KxdTPR8jn4RbtwcHxEpbLyDsmurIbM%2FLBW1aQGAVXzY%3D&reserved=0
>
> I will try to keep the PR up-to-date if any conflicts arise.
>
> From the discussion thread, I can carry over 1 +1 from Marton Elek to get
> us started.
>
> As it may take some time to review the large PR I will let the vote run for
> 14 days, closing at midnight GMT on 26th November.
>
> Please ask any questions here, on the PR or on ASF Slack.
>
> Thanks,
>
> Stephen.
>
Re: [VOTE] - Merge Decommission and Maintenance (HDDS-1880)
Posted by Vivek Ratnavel <vi...@apache.org>.
+1 to merge
Thanks for working on this Stephen!
On Thu, Nov 12, 2020 at 7:46 AM Stephen O'Donnell
<so...@cloudera.com.invalid> wrote:
> Following on from the discussion thread, I would like to call a vote on
> whether we should merge HDDS-1880 into master. This feature will enable
> decommission and maintenance mode for datanodes. The feature is working,
> but more work is needed to improve the usability etc. I feel the feature is
> stable and self contained enough to continue that work on the master branch
> now
>
> The overall design is under HDDS-1880 and there is a summary of the
> internals also attached to that Jira.
>
> A PR for the merge is here:
>
> https://github.com/apache/ozone/pull/1580
>
> I will try to keep the PR up-to-date if any conflicts arise.
>
> From the discussion thread, I can carry over 1 +1 from Marton Elek to get
> us started.
>
> As it may take some time to review the large PR I will let the vote run for
> 14 days, closing at midnight GMT on 26th November.
>
> Please ask any questions here, on the PR or on ASF Slack.
>
> Thanks,
>
> Stephen.
>
Re: [VOTE] - Merge Decommission and Maintenance (HDDS-1880)
Posted by Sammi Chen <sa...@apache.org>.
+1.
Thanks Stephen and Marton. It's great to have this feature available.
Bests,
Sammi
On Thu, Nov 12, 2020 at 11:46 PM Stephen O'Donnell
<so...@cloudera.com.invalid> wrote:
> Following on from the discussion thread, I would like to call a vote on
> whether we should merge HDDS-1880 into master. This feature will enable
> decommission and maintenance mode for datanodes. The feature is working,
> but more work is needed to improve the usability etc. I feel the feature is
> stable and self contained enough to continue that work on the master branch
> now
>
> The overall design is under HDDS-1880 and there is a summary of the
> internals also attached to that Jira.
>
> A PR for the merge is here:
>
> https://github.com/apache/ozone/pull/1580
>
> I will try to keep the PR up-to-date if any conflicts arise.
>
> From the discussion thread, I can carry over 1 +1 from Marton Elek to get
> us started.
>
> As it may take some time to review the large PR I will let the vote run for
> 14 days, closing at midnight GMT on 26th November.
>
> Please ask any questions here, on the PR or on ASF Slack.
>
> Thanks,
>
> Stephen.
>