[jira] [Commented] (GIRAPH-895) Trim the edges in Giraph

["Claudio Martella (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GIRAPH-895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13991173#comment-13991173 ] 

Claudio Martella commented on GIRAPH-895:
-----------------------------------------

this is an interesting memory-footprint improvement. I wonder though whether you trim the vertices in the right place, namely in the computecallable after a vertex is executed. this does indeed manage when the vertex is adding edges (to itself), but it does not manage when an edge is added to a vertex from another vertex via addEdgeRequest, at the end of the superstep. Shouldn't then we just do the trimming at the end of the superstep, and that's it?

> Trim the edges in Giraph
> ------------------------
>
>                 Key: GIRAPH-895
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-895
>             Project: Giraph
>          Issue Type: Improvement
>          Components: graph
>    Affects Versions: 1.1.0
>            Reporter: Sergey Edunov
>             Fix For: 1.1.0
>
>         Attachments: GIRAPH-895.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> In many Giraph applications, graphs are immutable, but edges are never trimmed to the proper size, after input phase. This means that on average we often use 1.5x memory for storing them. Considering we are often memory bounded, adding an option to trim the edges after the input phase will help reduce this excess memory usage. For mutable graphs, we can also provide an option for the same method to be called after each superstep.
> Review request: https://reviews.apache.org/r/21119/



--
This message was sent by Atlassian JIRA
(v6.2#6252)