[GitHub] chetanmeh commented on a change in pull request #4165: Update to Kamon 1.1.3 from 0.6 series

[GitBox <gi...@apache.org>]

chetanmeh commented on a change in pull request #4165: Update to Kamon 1.1.3 from 0.6 series
URL: https://github.com/apache/incubator-openwhisk/pull/4165#discussion_r240514286
 
 

 ##########
 File path: core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/Invoker.scala
 ##########
 @@ -59,10 +59,8 @@ object Invoker {
   def initKamon(instance: Int): Unit = {
     // Replace the hostname of the invoker to the assigned id of the invoker.
     val newKamonConfig = Kamon.config
-      .withValue(
-        "kamon.statsd.simple-metric-key-generator.hostname-override",
-        ConfigValueFactory.fromAnyRef(s"invoker$instance"))
-    Kamon.start(newKamonConfig)
+      .withValue("kamon.environment.host", ConfigValueFactory.fromAnyRef(s"invoker$instance"))
 
 Review comment:
   With Kamon 1.0 a new [environment][1] config section is added and individual reporters now rely on that for hostname and service name. See kamon-io/kamon-statsd#2 for relevant change. 
   
   [1]: https://github.com/kamon-io/Kamon/blob/master/kamon-core/src/main/resources/reference.conf#L3

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services