[jira] [Commented] (FELIX-4063) Avoid warnings when using @SlingServlet and @SlingFilter annotations

["Carsten Ziegeler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-4063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13656050#comment-13656050 ] 

Carsten Ziegeler commented on FELIX-4063:
-----------------------------------------

Thanks for your patch, Julian
I think, if no component should be generated by @SlingServert/SlingFilter than the properties should be set to private as otherwise, when applying this patch this will be public
In that case of course, if the additional component is not setting metatype to true, the warning will be printed. - We could also check for a component tag in that case, but that would only work if the component tag is scanned before these two and that would add some uncertainty.
                
> Avoid warnings when using @SlingServlet and @SlingFilter annotations
> --------------------------------------------------------------------
>
>                 Key: FELIX-4063
>                 URL: https://issues.apache.org/jira/browse/FELIX-4063
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven SCR Plugin
>    Affects Versions: scr annotations 1.9.2
>            Reporter: Julian Sedding
>            Assignee: Carsten Ziegeler
>            Priority: Minor
>         Attachments: FELIX-4063.patch
>
>
> FELIX-4033 introduced build-time warning messages for private properties defined for components with metatype = false.
> The @SlingServlet and @SlingFilter annotations set several properties to be private, thus causing warnings like the following to be reported if metatype = false (the default value).
> [WARNING] /path/TheServlet.java [0:0]: Property sling.servlet.methods in class TheServlet is set as private. This is redundant as no metatype will be generated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira