[jira] [Commented] (AMBARI-20630) Integrate stomp client library into agent code

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-20630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948977#comment-15948977 ] 

Hadoop QA commented on AMBARI-20630:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12861220/AMBARI-20630.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

        {color:red}-1 release audit{color}.  The applied patch generated 17 release audit warnings.

    {color:red}-1 javac{color:red}.  The patch appears to cause the build to fail.

Release audit warnings: https://builds.apache.org/job/Ambari-trunk-test-patch/11232//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/11232//console

This message is automatically generated.

> Integrate stomp client library into agent code
> ----------------------------------------------
>
>                 Key: AMBARI-20630
>                 URL: https://issues.apache.org/jira/browse/AMBARI-20630
>             Project: Ambari
>          Issue Type: Bug
>            Reporter: Andrew Onischuk
>            Assignee: Andrew Onischuk
>             Fix For: 3.0.0
>
>         Attachments: AMBARI-20630.patch, AMBARI-20630.patch
>
>
> It was decided to use stomp 4.1.17 (lastest version)
> Some points about the library:
>   * It has apache license
>   * It supports basic functionality we need. Events subscription/unsubscription, acks/nacks, transactions, sending events to server and has a very simple neat API. Here are the docs on it <http://jasonrbriggs.github.io/stomp.py/api.html>
>   * It does not require any non-default python libraries
>   * I have already tested it with a simple stomp server I have setup.
>   * Supports both Python2.x and Python3.x



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)