You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/29 14:17:17 UTC
[GitHub] [spark] wangyum opened a new pull request #30536: [SPARK-33589][SQL] Add try catch when opening session
wangyum opened a new pull request #30536:
URL: https://github.com/apache/spark/pull/30536
### What changes were proposed in this pull request?
This pr add try catch when opening session.
### Why are the changes needed?
Close opened session if the initialization fails.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
// TODO
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30536: [SPARK-33589][SQL] Close opened session if the initialization fails
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30536:
URL: https://github.com/apache/spark/pull/30536#issuecomment-735408341
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131929/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gatorsmile commented on a change in pull request #30536: [SPARK-33589][SQL] Close opened session if the initialization fails
Posted by GitBox <gi...@apache.org>.
gatorsmile commented on a change in pull request #30536:
URL: https://github.com/apache/spark/pull/30536#discussion_r541524866
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLSessionManager.scala
##########
@@ -52,24 +53,35 @@ private[hive] class SparkSQLSessionManager(hiveServer: HiveServer2, sqlContext:
val sessionHandle =
super.openSession(protocol, username, passwd, ipAddress, sessionConf, withImpersonation,
delegationToken)
- val session = super.getSession(sessionHandle)
- HiveThriftServer2.eventManager.onSessionCreated(
- session.getIpAddress, sessionHandle.getSessionId.toString, session.getUsername)
- val ctx = if (sqlContext.conf.hiveThriftServerSingleSession) {
- sqlContext
- } else {
- sqlContext.newSession()
+ try {
+ val session = super.getSession(sessionHandle)
+ HiveThriftServer2.eventManager.onSessionCreated(
+ session.getIpAddress, sessionHandle.getSessionId.toString, session.getUsername)
+ val ctx = if (sqlContext.conf.hiveThriftServerSingleSession) {
+ sqlContext
+ } else {
+ sqlContext.newSession()
+ }
+ ctx.setConf(HiveUtils.FAKE_HIVE_VERSION.key, HiveUtils.builtinHiveVersion)
+ ctx.setConf(SQLConf.DATETIME_JAVA8API_ENABLED, true)
+ val hiveSessionState = session.getSessionState
+ setConfMap(ctx, hiveSessionState.getOverriddenConfigurations)
+ setConfMap(ctx, hiveSessionState.getHiveVariables)
+ if (sessionConf != null && sessionConf.containsKey("use:database")) {
+ ctx.sql(s"use ${sessionConf.get("use:database")}")
+ }
+ sparkSqlOperationManager.sessionToContexts.put(sessionHandle, ctx)
+ sessionHandle
+ } catch {
+ case e: Exception =>
Review comment:
NonFatal ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30536: [SPARK-33589][SQL] Close opened session if the initialization fails
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30536:
URL: https://github.com/apache/spark/pull/30536#issuecomment-735507724
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30536: [SPARK-33589][SQL] Close opened session if the initialization fails
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30536:
URL: https://github.com/apache/spark/pull/30536#issuecomment-735407724
**[Test build #131929 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131929/testReport)** for PR 30536 at commit [`090dad4`](https://github.com/apache/spark/commit/090dad4e57b73b7c56cd746b48a1bf930ab6a4fb).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #30536: [SPARK-33589][SQL] Close opened session if the initialization fails
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #30536:
URL: https://github.com/apache/spark/pull/30536#discussion_r532311234
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLSessionManager.scala
##########
@@ -52,24 +53,35 @@ private[hive] class SparkSQLSessionManager(hiveServer: HiveServer2, sqlContext:
val sessionHandle =
super.openSession(protocol, username, passwd, ipAddress, sessionConf, withImpersonation,
delegationToken)
- val session = super.getSession(sessionHandle)
- HiveThriftServer2.eventManager.onSessionCreated(
- session.getIpAddress, sessionHandle.getSessionId.toString, session.getUsername)
- val ctx = if (sqlContext.conf.hiveThriftServerSingleSession) {
- sqlContext
- } else {
- sqlContext.newSession()
+ try {
+ val session = super.getSession(sessionHandle)
+ HiveThriftServer2.eventManager.onSessionCreated(
+ session.getIpAddress, sessionHandle.getSessionId.toString, session.getUsername)
+ val ctx = if (sqlContext.conf.hiveThriftServerSingleSession) {
+ sqlContext
+ } else {
+ sqlContext.newSession()
+ }
+ ctx.setConf(HiveUtils.FAKE_HIVE_VERSION.key, HiveUtils.builtinHiveVersion)
+ ctx.setConf(SQLConf.DATETIME_JAVA8API_ENABLED, true)
+ val hiveSessionState = session.getSessionState
+ setConfMap(ctx, hiveSessionState.getOverriddenConfigurations)
+ setConfMap(ctx, hiveSessionState.getHiveVariables)
+ if (sessionConf != null && sessionConf.containsKey("use:database")) {
+ ctx.sql(s"use ${sessionConf.get("use:database")}")
+ }
+ sparkSqlOperationManager.sessionToContexts.put(sessionHandle, ctx)
+ sessionHandle
+ } catch {
+ case e: Exception =>
+ try {
+ closeSession(sessionHandle)
+ } catch {
+ case t: Throwable =>
+ logWarning("Error closing session", t)
+ }
+ throw new HiveSQLException("Failed to open new session: " + e, e)
Review comment:
The logic is the same: https://github.com/apache/spark/blob/008a2ad1f836ff04fafd51a9c94c355ef35f1692/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/SessionManager.java#L273-L282
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gatorsmile commented on a change in pull request #30536: [SPARK-33589][SQL] Close opened session if the initialization fails
Posted by GitBox <gi...@apache.org>.
gatorsmile commented on a change in pull request #30536:
URL: https://github.com/apache/spark/pull/30536#discussion_r541524663
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLSessionManager.scala
##########
@@ -52,24 +53,35 @@ private[hive] class SparkSQLSessionManager(hiveServer: HiveServer2, sqlContext:
val sessionHandle =
super.openSession(protocol, username, passwd, ipAddress, sessionConf, withImpersonation,
delegationToken)
- val session = super.getSession(sessionHandle)
- HiveThriftServer2.eventManager.onSessionCreated(
- session.getIpAddress, sessionHandle.getSessionId.toString, session.getUsername)
- val ctx = if (sqlContext.conf.hiveThriftServerSingleSession) {
- sqlContext
- } else {
- sqlContext.newSession()
+ try {
+ val session = super.getSession(sessionHandle)
+ HiveThriftServer2.eventManager.onSessionCreated(
+ session.getIpAddress, sessionHandle.getSessionId.toString, session.getUsername)
+ val ctx = if (sqlContext.conf.hiveThriftServerSingleSession) {
+ sqlContext
+ } else {
+ sqlContext.newSession()
+ }
+ ctx.setConf(HiveUtils.FAKE_HIVE_VERSION.key, HiveUtils.builtinHiveVersion)
+ ctx.setConf(SQLConf.DATETIME_JAVA8API_ENABLED, true)
+ val hiveSessionState = session.getSessionState
+ setConfMap(ctx, hiveSessionState.getOverriddenConfigurations)
+ setConfMap(ctx, hiveSessionState.getHiveVariables)
+ if (sessionConf != null && sessionConf.containsKey("use:database")) {
+ ctx.sql(s"use ${sessionConf.get("use:database")}")
+ }
+ sparkSqlOperationManager.sessionToContexts.put(sessionHandle, ctx)
+ sessionHandle
+ } catch {
+ case e: Exception =>
+ try {
+ closeSession(sessionHandle)
+ } catch {
+ case t: Throwable =>
Review comment:
NonFatal ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30536: [SPARK-33589][SQL] Close opened session if the initialization fails
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30536:
URL: https://github.com/apache/spark/pull/30536#issuecomment-735408341
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131929/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #30536: [SPARK-33589][SQL] Close opened session if the initialization fails
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #30536:
URL: https://github.com/apache/spark/pull/30536
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30536: [SPARK-33589][SQL] Close opened session if the initialization fails
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30536:
URL: https://github.com/apache/spark/pull/30536#issuecomment-735403427
**[Test build #131929 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131929/testReport)** for PR 30536 at commit [`090dad4`](https://github.com/apache/spark/commit/090dad4e57b73b7c56cd746b48a1bf930ab6a4fb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30536: [SPARK-33589][SQL] Close opened session if the initialization fails
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30536:
URL: https://github.com/apache/spark/pull/30536#issuecomment-735408226
Build finished.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30536: [SPARK-33589][SQL] Close opened session if the initialization fails
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30536:
URL: https://github.com/apache/spark/pull/30536#issuecomment-735415389
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30536: [SPARK-33589][SQL] Close opened session if the initialization fails
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30536:
URL: https://github.com/apache/spark/pull/30536#issuecomment-735408226
Build finished.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #30536: [SPARK-33589][SQL] Close opened session if the initialization fails
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #30536:
URL: https://github.com/apache/spark/pull/30536#discussion_r541529236
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLSessionManager.scala
##########
@@ -52,24 +53,35 @@ private[hive] class SparkSQLSessionManager(hiveServer: HiveServer2, sqlContext:
val sessionHandle =
super.openSession(protocol, username, passwd, ipAddress, sessionConf, withImpersonation,
delegationToken)
- val session = super.getSession(sessionHandle)
- HiveThriftServer2.eventManager.onSessionCreated(
- session.getIpAddress, sessionHandle.getSessionId.toString, session.getUsername)
- val ctx = if (sqlContext.conf.hiveThriftServerSingleSession) {
- sqlContext
- } else {
- sqlContext.newSession()
+ try {
+ val session = super.getSession(sessionHandle)
+ HiveThriftServer2.eventManager.onSessionCreated(
+ session.getIpAddress, sessionHandle.getSessionId.toString, session.getUsername)
+ val ctx = if (sqlContext.conf.hiveThriftServerSingleSession) {
+ sqlContext
+ } else {
+ sqlContext.newSession()
+ }
+ ctx.setConf(HiveUtils.FAKE_HIVE_VERSION.key, HiveUtils.builtinHiveVersion)
+ ctx.setConf(SQLConf.DATETIME_JAVA8API_ENABLED, true)
+ val hiveSessionState = session.getSessionState
+ setConfMap(ctx, hiveSessionState.getOverriddenConfigurations)
+ setConfMap(ctx, hiveSessionState.getHiveVariables)
+ if (sessionConf != null && sessionConf.containsKey("use:database")) {
+ ctx.sql(s"use ${sessionConf.get("use:database")}")
+ }
+ sparkSqlOperationManager.sessionToContexts.put(sessionHandle, ctx)
+ sessionHandle
+ } catch {
+ case e: Exception =>
Review comment:
https://github.com/apache/spark/pull/30744
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30536: [SPARK-33589][SQL] Close opened session if the initialization fails
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30536:
URL: https://github.com/apache/spark/pull/30536#issuecomment-735403427
**[Test build #131929 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131929/testReport)** for PR 30536 at commit [`090dad4`](https://github.com/apache/spark/commit/090dad4e57b73b7c56cd746b48a1bf930ab6a4fb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30536: [SPARK-33589][SQL] Close opened session if the initialization fails
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30536:
URL: https://github.com/apache/spark/pull/30536#issuecomment-735415389
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #30536: [SPARK-33589][SQL] Close opened session if the initialization fails
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30536:
URL: https://github.com/apache/spark/pull/30536#issuecomment-735541729
late lgtm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #30536: [SPARK-33589][SQL] Close opened session if the initialization fails
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #30536:
URL: https://github.com/apache/spark/pull/30536#issuecomment-735421670
Seems reasonable to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #30536: [SPARK-33589][SQL] Close opened session if the initialization fails
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #30536:
URL: https://github.com/apache/spark/pull/30536#discussion_r532311234
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLSessionManager.scala
##########
@@ -52,24 +53,35 @@ private[hive] class SparkSQLSessionManager(hiveServer: HiveServer2, sqlContext:
val sessionHandle =
super.openSession(protocol, username, passwd, ipAddress, sessionConf, withImpersonation,
delegationToken)
- val session = super.getSession(sessionHandle)
- HiveThriftServer2.eventManager.onSessionCreated(
- session.getIpAddress, sessionHandle.getSessionId.toString, session.getUsername)
- val ctx = if (sqlContext.conf.hiveThriftServerSingleSession) {
- sqlContext
- } else {
- sqlContext.newSession()
+ try {
+ val session = super.getSession(sessionHandle)
+ HiveThriftServer2.eventManager.onSessionCreated(
+ session.getIpAddress, sessionHandle.getSessionId.toString, session.getUsername)
+ val ctx = if (sqlContext.conf.hiveThriftServerSingleSession) {
+ sqlContext
+ } else {
+ sqlContext.newSession()
+ }
+ ctx.setConf(HiveUtils.FAKE_HIVE_VERSION.key, HiveUtils.builtinHiveVersion)
+ ctx.setConf(SQLConf.DATETIME_JAVA8API_ENABLED, true)
+ val hiveSessionState = session.getSessionState
+ setConfMap(ctx, hiveSessionState.getOverriddenConfigurations)
+ setConfMap(ctx, hiveSessionState.getHiveVariables)
+ if (sessionConf != null && sessionConf.containsKey("use:database")) {
+ ctx.sql(s"use ${sessionConf.get("use:database")}")
+ }
+ sparkSqlOperationManager.sessionToContexts.put(sessionHandle, ctx)
+ sessionHandle
+ } catch {
+ case e: Exception =>
+ try {
+ closeSession(sessionHandle)
+ } catch {
+ case t: Throwable =>
+ logWarning("Error closing session", t)
+ }
+ throw new HiveSQLException("Failed to open new session: " + e, e)
Review comment:
The logic same to https://github.com/apache/spark/blob/008a2ad1f836ff04fafd51a9c94c355ef35f1692/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/SessionManager.java#L273-L282
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org