You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "liuzqt (via GitHub)" <gi...@apache.org> on 2023/08/02 03:15:01 UTC
[GitHub] [spark] liuzqt opened a new pull request, #42286: rename shouldBroadcast to isDynamicPruning
liuzqt opened a new pull request, #42286:
URL: https://github.com/apache/spark/pull/42286
### What changes were proposed in this pull request?
Rename `shouldBroadcast` param to `isDynamicPruning`.
### Why are the changes needed?
Explicitly indicating the behavior mode of DPP
### Does this PR introduce _any_ user-facing change?
NO
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #42286: [MINOR][SQL] Rename shouldBroadcast to isDynamicPruning in InSubqueryExec
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #42286: [MINOR][SQL] Rename shouldBroadcast to isDynamicPruning in InSubqueryExec
URL: https://github.com/apache/spark/pull/42286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] liuzqt commented on a diff in pull request #42286: [MINOR][SQL] Rename shouldBroadcast to isDynamicPruning in InSubqueryExec
Posted by "liuzqt (via GitHub)" <gi...@apache.org>.
liuzqt commented on code in PR #42286:
URL: https://github.com/apache/spark/pull/42286#discussion_r1283530842
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala:
##########
@@ -117,7 +117,7 @@ case class InSubqueryExec(
child: Expression,
plan: BaseSubqueryExec,
exprId: ExprId,
- shouldBroadcast: Boolean = false,
+ isDynamicPruning: Boolean = true,
Review Comment:
DPP has more usage in this case, let's keep it `true` by default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #42286: [MINOR][SQL] Rename shouldBroadcast to isDynamicPruning in InSubqueryExec
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #42286:
URL: https://github.com/apache/spark/pull/42286#discussion_r1282560911
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala:
##########
@@ -117,7 +117,7 @@ case class InSubqueryExec(
child: Expression,
plan: BaseSubqueryExec,
exprId: ExprId,
- shouldBroadcast: Boolean = false,
+ isDynamicPruning: Boolean = true,
Review Comment:
how many places create `InSubqueryExec` for DPP? If it's very few, maybe `false` is a better default value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #42286: [MINOR][SQL] Rename shouldBroadcast to isDynamicPruning in InSubqueryExec
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #42286:
URL: https://github.com/apache/spark/pull/42286#issuecomment-1675921683
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org