You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/12/04 10:06:48 UTC
[GitHub] [camel] Liroyd opened a new pull request #4720: CAMEL-15917: Resilience4j Property Component doesn't work for configu…
Liroyd opened a new pull request #4720:
URL: https://github.com/apache/camel/pull/4720
[CAMEL-15917] Resilience4j Property Component doesn't work for configurationRef
Add support of property placeholder for resilience4j circuit breaker configurationRef in routes definitions.
Before for `<circuitBreaker configurationRef="{{myName}}">`,
`{{myName}}` property was not resolved based on configuration files.
Now it will lookup in configuration. If there is no property configured, value will be used as is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #4720: CAMEL-15917: Resilience4j Property Component doesn't work for configu…
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4720:
URL: https://github.com/apache/camel/pull/4720#issuecomment-738696331
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Liroyd commented on pull request #4720: CAMEL-15917: Resilience4j Property Component doesn't work for configu…
Posted by GitBox <gi...@apache.org>.
Liroyd commented on pull request #4720:
URL: https://github.com/apache/camel/pull/4720#issuecomment-738772640
Please check updated review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Liroyd commented on pull request #4720: CAMEL-15917: Resilience4j Property Component doesn't work for configu…
Posted by GitBox <gi...@apache.org>.
Liroyd commented on pull request #4720:
URL: https://github.com/apache/camel/pull/4720#issuecomment-738732205
It's already done as parseString for camle-hystrix and camel-microprofile-fault-tolerance.
Will change for resilience4j only
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #4720: CAMEL-15917: Resilience4j Property Component doesn't work for configu…
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #4720:
URL: https://github.com/apache/camel/pull/4720#issuecomment-738719490
And we need this for all 3 circuit breakers
camel-hystrix, camel-resilience4j, camel-microprofile-fault-tolerance
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Liroyd commented on pull request #4720: CAMEL-15917: Resilience4j Property Component doesn't work for configu…
Posted by GitBox <gi...@apache.org>.
Liroyd commented on pull request #4720:
URL: https://github.com/apache/camel/pull/4720#issuecomment-738695535
Already done for master, please check https://github.com/apache/camel/pull/4721
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Liroyd edited a comment on pull request #4720: CAMEL-15917: Resilience4j Property Component doesn't work for configu…
Posted by GitBox <gi...@apache.org>.
Liroyd edited a comment on pull request #4720:
URL: https://github.com/apache/camel/pull/4720#issuecomment-738732205
It's already done as parseString for camle-hystrix
Will change for resilience4j and camel-microprofile-fault-tolerance
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #4720: CAMEL-15917: Resilience4j Property Component doesn't work for configu…
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4720:
URL: https://github.com/apache/camel/pull/4720#issuecomment-738695104
Can you open a PR for master too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #4720: CAMEL-15917: Resilience4j Property Component doesn't work for configu…
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #4720:
URL: https://github.com/apache/camel/pull/4720
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org