You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Tomasz Blachowicz (JIRA)" <ji...@apache.org> on 2006/11/30 17:21:22 UTC
[jira] Commented: (LANG-102) [lang] Refactor Entities methods
[ http://issues.apache.org/jira/browse/LANG-102?page=comments#action_12454690 ]
Tomasz Blachowicz commented on LANG-102:
----------------------------------------
I have one comment regarding the patch I've contibuted.
There is a minor issue with IOException that could be thown by Entities.*escape(Writer, String) methods. Methods Entities.*escape(String) don't declare IOException so I decided to catch it and wrap within bare RuntimeException. Although the exception can't occur since I pass java.io.StringWriter instance into Entities.*escape(Writer, String) methods.
If you don't like this approach pleas let me know.
> [lang] Refactor Entities methods
> --------------------------------
>
> Key: LANG-102
> URL: http://issues.apache.org/jira/browse/LANG-102
> Project: Commons Lang
> Issue Type: Bug
> Affects Versions: 3.0
> Environment: Operating System: other
> Platform: Other
> Reporter: Henri Yandell
> Fix For: 3.0
>
> Attachments: Entries.java.patch
>
>
> The pairs of escape and unescape methods in Entities need to be modified so that
> they call each other (one escape to the other escape etc). Otherwise there's a
> large chunk of repeated code that gives us a high chance of errors.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org