You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2024/05/29 20:33:59 UTC

[PR] adds unit test for compaction commit and fixes bug found [accumulo]

keith-turner opened a new pull request, #4616:
URL: https://github.com/apache/accumulo/pull/4616

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] adds unit test for compaction commit and fixes bug found [accumulo]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner merged PR #4616:
URL: https://github.com/apache/accumulo/pull/4616


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] adds unit test for compaction commit and fixes bug found [accumulo]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #4616:
URL: https://github.com/apache/accumulo/pull/4616#discussion_r1620702448


##########
server/manager/src/main/java/org/apache/accumulo/manager/compaction/coordinator/commit/CommitCompaction.java:
##########
@@ -257,6 +256,7 @@ public static boolean canCommitCompaction(ExternalCompactionId ecid,
         LOG.debug(
             "Received completion notification for user compaction where its fate txid did not match the tablets {} {} {} {}",
             ecid, extent, ecm.getFateId(), tabletMetadata.getSelectedFiles().getFateId());
+        return false;

Review Comment:
   It does not exist in earlier versions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] adds unit test for compaction commit and fixes bug found [accumulo]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #4616:
URL: https://github.com/apache/accumulo/pull/4616#discussion_r1619443408


##########
server/manager/src/main/java/org/apache/accumulo/manager/compaction/coordinator/commit/CommitCompaction.java:
##########
@@ -257,6 +256,7 @@ public static boolean canCommitCompaction(ExternalCompactionId ecid,
         LOG.debug(
             "Received completion notification for user compaction where its fate txid did not match the tablets {} {} {} {}",
             ecid, extent, ecm.getFateId(), tabletMetadata.getSelectedFiles().getFateId());
+        return false;

Review Comment:
   This was a bug found by the new unit test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] adds unit test for compaction commit and fixes bug found [accumulo]

Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #4616:
URL: https://github.com/apache/accumulo/pull/4616#discussion_r1620564856


##########
server/manager/src/main/java/org/apache/accumulo/manager/compaction/coordinator/commit/CommitCompaction.java:
##########
@@ -257,6 +256,7 @@ public static boolean canCommitCompaction(ExternalCompactionId ecid,
         LOG.debug(
             "Received completion notification for user compaction where its fate txid did not match the tablets {} {} {} {}",
             ecid, extent, ecm.getFateId(), tabletMetadata.getSelectedFiles().getFateId());
+        return false;

Review Comment:
   We should check that this does not exist in an earlier version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org