[GitHub] [openwhisk] rabbah commented on a change in pull request #4646: Serialize `updated` value of entity document in response

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #4646: Serialize `updated` value of entity document in response
URL: https://github.com/apache/openwhisk/pull/4646#discussion_r340741233
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/entity/WhiskAction.scala
 ##########
 @@ -133,7 +135,8 @@ case class WhiskAction(namespace: EntityPath,
                        limits: ActionLimits = ActionLimits(),
                        version: SemVer = SemVer(),
                        publish: Boolean = false,
-                       annotations: Parameters = Parameters())
+                       annotations: Parameters = Parameters(),
+                       override val updated: Instant = WhiskEntity.currentMillis())
 
 Review comment:
   this seems like an unfortunate modification because we're using the default serializers. 
   i _think_ we would not need to modify this class at all otherwise (or the other subtypes of whisk entity) and my preference would be to avoid making this value visible in the constructor.
   
   will try to see if there's a convenient refactoring that avoid modifying the constructors while reducing impact on serdes methods.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services