You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/02/06 21:35:35 UTC
[GitHub] [druid] gianm commented on issue #9314: Add HashVectorGrouper based
on MemoryOpenHashTable.
gianm commented on issue #9314: Add HashVectorGrouper based on MemoryOpenHashTable.
URL: https://github.com/apache/druid/pull/9314#issuecomment-583122340
I just looked at it. It's complaining that `keySpace.getInt(i * Integer.BYTES)` accepts a long and in theory `i * Integer.BYTES` could overflow. It's not very plausible: it would only happen if the vector size was crazy huge. I added a check to the start of the method that will detect this and block it. I'm not sure if LGTM will be smart enough to understand it, but it means the issue isn't real.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org