You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by bryancall <gi...@git.apache.org> on 2016/06/27 21:41:05 UTC
[GitHub] trafficserver pull request #751: TS-4542: ASAN error with HTTP/2 priority
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/751
TS-4542: ASAN error with HTTP/2 priority
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4542
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/751.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #751
----
commit a860b62741230197bdd0cd8110c466588972872a
Author: Bryan Call <bc...@apache.org>
Date: 2016-06-27T21:40:33Z
TS-4542: ASAN error with HTTP/2 priority
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #751: TS-4542: ASAN error with HTTP/2 priority
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/751
This seems good, +1.
One comment, as discussed on the IRC:
It seems unfortunate that we have two state variables (closed=true, and the _state= HTTP2_STREAM_STATE_CLOSED for H2) indicating the same state. It seems that we ended up with this bug because we set the closed=true, but forgot to update the _state.
At a minimum, maybe we should add some strategic ink_assert() in places where these two can get obviously out of sync?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #751: TS-4542: ASAN error with HTTP/2 priority
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/751
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/253/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #751: TS-4542: ASAN error with HTTP/2 priority
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/751
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #751: TS-4542: ASAN error with HTTP/2 priority
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/751
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/359/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---