You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@parquet.apache.org by "Wes McKinney (JIRA)" <ji...@apache.org> on 2016/01/29 20:41:39 UTC

[jira] [Commented] (PARQUET-463) Add DCHECK* macros for assertions in debug builds

    [ https://issues.apache.org/jira/browse/PARQUET-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124074#comment-15124074 ] 

Wes McKinney commented on PARQUET-463:
--------------------------------------

These macros are all in Google's glog library, so I (or someone) can add glog to the build toolchain and add includes to {{parquet/util/logging.h}}.

> Add DCHECK* macros for assertions in debug builds
> -------------------------------------------------
>
>                 Key: PARQUET-463
>                 URL: https://issues.apache.org/jira/browse/PARQUET-463
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-cpp
>            Reporter: Wes McKinney
>            Priority: Minor
>
> Some of these macros are already defined in {{parquet/util/logging.h}}, but they are no-ops. This will assist in "can't fail" assertions. See https://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREACHED-



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)