You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Mikhail Bautin (Created) (JIRA)" <ji...@apache.org> on 2011/11/08 01:30:51 UTC
[jira] [Created] (HBASE-4758) [89-fb] Make test methods independent
in TestMasterTransitions
[89-fb] Make test methods independent in TestMasterTransitions
--------------------------------------------------------------
Key: HBASE-4758
URL: https://issues.apache.org/jira/browse/HBASE-4758
Project: HBase
Issue Type: Bug
Reporter: Mikhail Bautin
Assignee: Mikhail Bautin
Priority: Minor
Currently TestMasterTransitions is flaky, and one way to hopefully make it more stable is to create a separate MiniHBaseCluster for every test method, and get rid of BeforeClass/AfterClass. So far I have successfully run TestMasterTransitions a few times with the fix, while it was failing without the fix.
TestMasterTransitions in trunk is a different story (most of the test is commented out in the trunk) and is out of scope of this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4758) [89-fb] Make test methods
independent in TestMasterTransitions
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210010#comment-13210010 ]
Phabricator commented on HBASE-4758:
------------------------------------
mbautin has committed the revision "[jira] [HBASE-4758] [89-fb] Make test methods independent in TestMasterTransitions".
REVISION DETAIL
https://reviews.facebook.net/D315
COMMIT
https://reviews.facebook.net/rHBASEEIGHTNINEFBBRANCH1245302
> [89-fb] Make test methods independent in TestMasterTransitions
> --------------------------------------------------------------
>
> Key: HBASE-4758
> URL: https://issues.apache.org/jira/browse/HBASE-4758
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D315.1.patch, D315.2.patch
>
>
> Currently TestMasterTransitions is flaky, and one way to hopefully make it more stable is to create a separate MiniHBaseCluster for every test method, and get rid of BeforeClass/AfterClass. So far I have successfully run TestMasterTransitions a few times with the fix, while it was failing without the fix.
> TestMasterTransitions in trunk is a different story (most of the test is commented out in the trunk) and is out of scope of this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4758) [89-fb] Make test methods independent
in TestMasterTransitions
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4758:
-------------------------------
Attachment: D315.1.patch
mbautin requested code review of "[jira] [HBASE-4758] [89-fb] Make test methods independent in TestMasterTransitions".
Reviewers: tedyu, stack, Liyin, JIRA
Currently TestMasterTransitions is flaky, and one way to hopefully make it more stable is to create a separate MiniHBaseCluster for every test method, and get rid of BeforeClass/AfterClass. So far I have successfully run TestMasterTransitions a few times with the fix, while it was failing without the fix.
TestMasterTransitions in trunk is a different story (most of the test is commented out in the trunk) and is out of scope of this JIRA.
TEST PLAN
Run TestMasterTransitions
REVISION DETAIL
https://reviews.facebook.net/D315
AFFECTED FILES
src/test/java/org/apache/hadoop/hbase/master/TestMasterTransitions.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/645/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> [89-fb] Make test methods independent in TestMasterTransitions
> --------------------------------------------------------------
>
> Key: HBASE-4758
> URL: https://issues.apache.org/jira/browse/HBASE-4758
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D315.1.patch
>
>
> Currently TestMasterTransitions is flaky, and one way to hopefully make it more stable is to create a separate MiniHBaseCluster for every test method, and get rid of BeforeClass/AfterClass. So far I have successfully run TestMasterTransitions a few times with the fix, while it was failing without the fix.
> TestMasterTransitions in trunk is a different story (most of the test is commented out in the trunk) and is out of scope of this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4758) [89-fb] Make test methods
independent in TestMasterTransitions
Posted by "Mikhail Bautin (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Bautin resolved HBASE-4758.
-----------------------------------
Resolution: Fixed
Release Note: This issue is specific to 89-fb. The patch will be synced into the official hbase-89-fb-apache branch shortly.
> [89-fb] Make test methods independent in TestMasterTransitions
> --------------------------------------------------------------
>
> Key: HBASE-4758
> URL: https://issues.apache.org/jira/browse/HBASE-4758
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D315.1.patch, D315.2.patch
>
>
> Currently TestMasterTransitions is flaky, and one way to hopefully make it more stable is to create a separate MiniHBaseCluster for every test method, and get rid of BeforeClass/AfterClass. So far I have successfully run TestMasterTransitions a few times with the fix, while it was failing without the fix.
> TestMasterTransitions in trunk is a different story (most of the test is commented out in the trunk) and is out of scope of this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4758) [89-fb] Make test methods independent
in TestMasterTransitions
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4758:
-------------------------------
Attachment: D315.2.patch
mbautin updated the revision "[jira] [HBASE-4758] [89-fb] Make test methods independent in TestMasterTransitions".
Reviewers: tedyu, stack, Liyin, JIRA, Karthik
Rebase on recent changes in 89-fb.
REVISION DETAIL
https://reviews.facebook.net/D315
AFFECTED FILES
src/test/java/org/apache/hadoop/hbase/master/TestMasterTransitions.java
> [89-fb] Make test methods independent in TestMasterTransitions
> --------------------------------------------------------------
>
> Key: HBASE-4758
> URL: https://issues.apache.org/jira/browse/HBASE-4758
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D315.1.patch, D315.2.patch
>
>
> Currently TestMasterTransitions is flaky, and one way to hopefully make it more stable is to create a separate MiniHBaseCluster for every test method, and get rid of BeforeClass/AfterClass. So far I have successfully run TestMasterTransitions a few times with the fix, while it was failing without the fix.
> TestMasterTransitions in trunk is a different story (most of the test is commented out in the trunk) and is out of scope of this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4758) [89-fb] Make test methods
independent in TestMasterTransitions
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148745#comment-13148745 ]
Phabricator commented on HBASE-4758:
------------------------------------
tedyu has commented on the revision "[jira] [HBASE-4758] [89-fb] Make test methods independent in TestMasterTransitions".
+1 as well.
REVISION DETAIL
https://reviews.facebook.net/D315
> [89-fb] Make test methods independent in TestMasterTransitions
> --------------------------------------------------------------
>
> Key: HBASE-4758
> URL: https://issues.apache.org/jira/browse/HBASE-4758
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D315.1.patch
>
>
> Currently TestMasterTransitions is flaky, and one way to hopefully make it more stable is to create a separate MiniHBaseCluster for every test method, and get rid of BeforeClass/AfterClass. So far I have successfully run TestMasterTransitions a few times with the fix, while it was failing without the fix.
> TestMasterTransitions in trunk is a different story (most of the test is commented out in the trunk) and is out of scope of this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4758) [89-fb] Make test methods
independent in TestMasterTransitions
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148810#comment-13148810 ]
stack commented on HBASE-4758:
------------------------------
@Mikhail Stick the patch up here so we can commit it.
> [89-fb] Make test methods independent in TestMasterTransitions
> --------------------------------------------------------------
>
> Key: HBASE-4758
> URL: https://issues.apache.org/jira/browse/HBASE-4758
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D315.1.patch
>
>
> Currently TestMasterTransitions is flaky, and one way to hopefully make it more stable is to create a separate MiniHBaseCluster for every test method, and get rid of BeforeClass/AfterClass. So far I have successfully run TestMasterTransitions a few times with the fix, while it was failing without the fix.
> TestMasterTransitions in trunk is a different story (most of the test is commented out in the trunk) and is out of scope of this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4758) [89-fb] Make test methods
independent in TestMasterTransitions
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148740#comment-13148740 ]
Phabricator commented on HBASE-4758:
------------------------------------
Karthik has accepted the revision "[jira] [HBASE-4758] [89-fb] Make test methods independent in TestMasterTransitions".
Nice fix!
REVISION DETAIL
https://reviews.facebook.net/D315
> [89-fb] Make test methods independent in TestMasterTransitions
> --------------------------------------------------------------
>
> Key: HBASE-4758
> URL: https://issues.apache.org/jira/browse/HBASE-4758
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D315.1.patch
>
>
> Currently TestMasterTransitions is flaky, and one way to hopefully make it more stable is to create a separate MiniHBaseCluster for every test method, and get rid of BeforeClass/AfterClass. So far I have successfully run TestMasterTransitions a few times with the fix, while it was failing without the fix.
> TestMasterTransitions in trunk is a different story (most of the test is commented out in the trunk) and is out of scope of this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira