You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/02/21 19:03:41 UTC

[GitHub] hackeo1 closed pull request #63: CB-13914: (android) Fix in plugin config to access AndroidManifest

hackeo1 closed pull request #63: CB-13914: (android) Fix in plugin config to access AndroidManifest
URL: https://github.com/apache/cordova-plugin-network-information/pull/63
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/plugin.xml b/plugin.xml
index 06b67f8..7b9071f 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -39,6 +39,9 @@ xmlns:android="http://schemas.android.com/apk/res/android"
         <clobbers target="Connection" />
     </js-module>
 
+    <engines>
+      <engine name="cordova-android" version=">=7.0.0" />
+    </engines>
 
     <!-- android -->
     <platform name="android">
@@ -48,9 +51,9 @@ xmlns:android="http://schemas.android.com/apk/res/android"
             </feature>
         </config-file>
 
-        <config-file target="AndroidManifest.xml" parent="/*">
+        <edit-config file="app/src/main/AndroidManifest.xml" target="/*" mode="merge">
             <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
-        </config-file>
+        </edit-config>
 
         <source-file src="src/android/NetworkManager.java" target-dir="src/org/apache/cordova/networkinformation" />
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org