You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by manuzhang <gi...@git.apache.org> on 2017/06/21 00:46:53 UTC
[GitHub] incubator-gearpump pull request #188: [GEARPUMP-318] Exclude maven-plugin-ap...
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/188
[GEARPUMP-318] Exclude maven-plugin-api dependency from sbt-assembly
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the commit message is formatted like:
`[GEARPUMP-<Jira issue #>] Meaningful description of pull request`
- [ ] Make sure tests pass via `sbt clean test`.
- [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manuzhang/incubator-gearpump sbt-assembly
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gearpump/pull/188.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #188
----
commit 4857ff7e46fbaf55dc9fc6fa21d54e03ec33807c
Author: manuzhang <ow...@gmail.com>
Date: 2017-06-21T00:44:39Z
[GEARPUMP-318] Exclude maven-plugin-api dependency from sbt-assembly
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #188: [GEARPUMP-318] Exclude maven-plugin-api depen...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/188
R: @huafengw
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #188: [GEARPUMP-318] Exclude maven-plugin-api depen...
Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/188
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #188: [GEARPUMP-318] Exclude maven-plugin-ap...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/188
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #188: [GEARPUMP-318] Exclude maven-plugin-api depen...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/188
# [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/188?src=pr&el=h1) Report
> Merging [#188](https://codecov.io/gh/apache/incubator-gearpump/pull/188?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gearpump/commit/83e1eb63643274d3914470cbb60b9908b2885e8e?src=pr&el=desc) will **increase** coverage by `1.26%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #188 +/- ##
==========================================
+ Coverage 70.29% 71.55% +1.26%
==========================================
Files 189 189
Lines 6106 6106
Branches 537 537
==========================================
+ Hits 4292 4369 +77
+ Misses 1814 1737 -77
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---