[jira] [Work logged] (BEAM-14525) Unable to find Proto getters in certain cases

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-14525?focusedWorklogId=775323&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-775323 ]

ASF GitHub Bot logged work on BEAM-14525:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/May/22 02:53
            Start Date: 27/May/22 02:53
    Worklog Time Spent: 10m 
      Work Description: nbali opened a new pull request, #17775:
URL: https://github.com/apache/beam/pull/17775

   https://issues.apache.org/jira/browse/BEAM-14525
   
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - ~[ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).~
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 775323)
    Remaining Estimate: 0h
            Time Spent: 10m

> Unable to find Proto getters in certain cases
> ---------------------------------------------
>
>                 Key: BEAM-14525
>                 URL: https://issues.apache.org/jira/browse/BEAM-14525
>             Project: Beam
>          Issue Type: Bug
>          Components: extensions-java-protobuf
>            Reporter: Balázs Németh
>            Priority: P2
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Proto property name: *item2partner_id* 
> Generated java library method names:
>  * *hasItem2PartnerId*
>  * *getItem2PartnerId*
>  * *setItem2PartnerId*
>  * *clearItem2PartnerId*
> org.apache.beam.sdk.extensions.protobuf.ProtoByteBuddyUtils generated getter name:
>  * *getItem2partnerId*
>  
> Notice the case difference of 'p'. The getter method name creation isn't aligned with protobuf standards.
> See:
>  - [https://github.com/protocolbuffers/protobuf/blob/ec79d0d328c7e6cea15cc27fbeb9b018ca289590/src/google/protobuf/compiler/java/helpers.cc#L246-L248]
>  - [https://github.com/protocolbuffers/protobuf/blob/ec79d0d328c7e6cea15cc27fbeb9b018ca289590/src/google/protobuf/compiler/java/helpers.cc#L173-L208]
>  
> According this logic anything that isn't A-Za-z makes the next character uppercase.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)