You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by syed <gi...@git.apache.org> on 2016/11/24 03:31:02 UTC
[GitHub] cloudstack pull request #1772: Fix template sync for region store.
GitHub user syed opened a pull request:
https://github.com/apache/cloudstack/pull/1772
Fix template sync for region store.
When using a region store like Swift or S3 as secondary storage,
the `zoneId` can be null. This causes an exception when we try
to convert it to a `long`. This fix guards against that.
Before this fix, if you restart the management server, all the templates
would change to "NOT READY" because the code which syncs the NFS cache
and the object store crashes due to the above mentioned issue.
This PR fixes that.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/syed/cloudstack template-sync-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1772.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1772
----
commit 5386ffc7117b0d29bc8ab40014c90b81bf9aae16
Author: Syed <sy...@gmail.com>
Date: 2016-11-23T16:31:59Z
Fix template sync for region store.
When using a region store like Swift or S3 as secondary storage,
the `zoneId` can be null. This causes an exception when we try
to convert it to a `long`. This fix guards against that.
Before this fix, if you restart the management server, all the templates
would change to "NOT READY" because the code which syncs the NFS cache
and the object store crashes due to the above mentioned issue.
This PR fixes that.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1772: CLOUDSTACK-9627 Fix template sync for region store.
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1772
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-309
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1772: CLOUDSTACK-9627 Fix template sync for region ...
Posted by syed <gi...@git.apache.org>.
Github user syed closed the pull request at:
https://github.com/apache/cloudstack/pull/1772
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1772: CLOUDSTACK-9627 Fix template sync for region store.
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1772
LGTM, tests and review LGTM (one failing VPC/rvr is known intermittent failure and can be ignored). Merging this now. Thanks @syed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1772: CLOUDSTACK-9627 Fix template sync for region store.
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1772
@syed can you amend the git commit message with this format to include the JIRA id: `CLOUDSTACK-xxx: one line summary`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1772: Fix template sync for region store.
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1772
@syed can you add a JIRA id for this and use that in the git commit summary.
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1772: CLOUDSTACK-9627 Fix template sync for region store.
Posted by syed <gi...@git.apache.org>.
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1772
Thanks @rhtyd . I've created an issue in JIRA and updated the summary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1772: CLOUDSTACK-9627 Fix template sync for region store.
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1772
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1772: CLOUDSTACK-9627 Fix template sync for region ...
Posted by syed <gi...@git.apache.org>.
GitHub user syed reopened a pull request:
https://github.com/apache/cloudstack/pull/1772
CLOUDSTACK-9627 Fix template sync for region store.
When using a region store like Swift or S3 as secondary storage,
the `zoneId` can be null. This causes an exception when we try
to convert it to a `long`. This fix guards against that.
Before this fix, if you restart the management server, all the templates
would change to "NOT READY" because the code which syncs the NFS cache
and the object store crashes due to the above mentioned issue.
This PR fixes that.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/syed/cloudstack template-sync-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1772.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1772
----
commit 5d274bba512d3620a46dd9e43757d6800d81e2ea
Author: Syed <sy...@gmail.com>
Date: 2016-11-23T16:31:59Z
CLOUDSTACK-9627:Fix template sync for region store
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1772: CLOUDSTACK-9627 Fix template sync for region store.
Posted by syed <gi...@git.apache.org>.
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1772
@rhtyd Done!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1772: CLOUDSTACK-9627 Fix template sync for region ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1772
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1772: CLOUDSTACK-9627 Fix template sync for region store.
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1772
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1772: CLOUDSTACK-9627 Fix template sync for region store.
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1772
<b>Trillian test result (tid-549)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28389 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1772-t549-kvm-centos7.zip
Test completed. 48 look ok, 1 have error(s)
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_redundant_VPC_default_routes | `Failure` | 863.18 | test_vpc_redundant.py
test_01_vpc_site2site_vpn | Success | 164.47 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 60.78 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 249.73 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 268.77 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 592.43 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 515.12 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1468.88 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 547.23 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1313.54 | test_vpc_redundant.py
test_09_delete_detached_volume | Success | 16.34 | test_volumes.py
test_08_resize_volume | Success | 15.32 | test_volumes.py
test_07_resize_fail | Success | 20.40 | test_volumes.py
test_06_download_detached_volume | Success | 15.38 | test_volumes.py
test_05_detach_volume | Success | 100.24 | test_volumes.py
test_04_delete_attached_volume | Success | 10.14 | test_volumes.py
test_03_download_attached_volume | Success | 15.22 | test_volumes.py
test_02_attach_volume | Success | 44.86 | test_volumes.py
test_01_create_volume | Success | 653.12 | test_volumes.py
test_deploy_vm_multiple | Success | 257.60 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.82 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.18 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 80.96 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.09 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 130.67 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 130.88 | test_vm_life_cycle.py
test_02_start_vm | Success | 5.10 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.26 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 95.67 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.03 | test_templates.py
test_05_template_permissions | Success | 0.05 | test_templates.py
test_04_extract_template | Success | 5.26 | test_templates.py
test_03_delete_template | Success | 5.08 | test_templates.py
test_02_edit_template | Success | 90.09 | test_templates.py
test_01_create_template | Success | 85.59 | test_templates.py
test_10_destroy_cpvm | Success | 171.28 | test_ssvm.py
test_09_destroy_ssvm | Success | 204.35 | test_ssvm.py
test_08_reboot_cpvm | Success | 166.38 | test_ssvm.py
test_07_reboot_ssvm | Success | 138.19 | test_ssvm.py
test_06_stop_cpvm | Success | 141.43 | test_ssvm.py
test_05_stop_ssvm | Success | 144.05 | test_ssvm.py
test_04_cpvm_internals | Success | 1.73 | test_ssvm.py
test_03_ssvm_internals | Success | 3.37 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.09 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.10 | test_ssvm.py
test_01_snapshot_root_disk | Success | 16.07 | test_snapshots.py
test_04_change_offering_small | Success | 244.34 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py
test_01_create_service_offering | Success | 0.11 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.09 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.14 | test_secondary_storage.py
test_09_reboot_router | Success | 40.26 | test_routers.py
test_08_start_router | Success | 30.36 | test_routers.py
test_07_stop_router | Success | 15.72 | test_routers.py
test_06_router_advanced | Success | 0.04 | test_routers.py
test_05_router_basic | Success | 0.03 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.53 | test_routers.py
test_03_restart_network_cleanup | Success | 60.43 | test_routers.py
test_02_router_internal_adv | Success | 0.85 | test_routers.py
test_01_router_internal_basic | Success | 0.49 | test_routers.py
test_router_dns_guestipquery | Success | 78.00 | test_router_dns.py
test_router_dns_externalipquery | Success | 0.04 | test_router_dns.py
test_router_dhcphosts | Success | 282.12 | test_router_dhcphosts.py
test_router_dhcp_opts | Success | 21.37 | test_router_dhcphosts.py
test_01_updatevolumedetail | Success | 5.52 | test_resource_detail.py
test_01_reset_vm_on_reboot | Success | 181.18 | test_reset_vm_on_reboot.py
test_createRegion | Success | 0.04 | test_regions.py
test_create_pvlan_network | Success | 0.28 | test_pvlan.py
test_dedicatePublicIpRange | Success | 0.45 | test_public_ip_range.py
test_04_rvpc_privategw_static_routes | Success | 555.65 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | Success | 570.25 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | Success | 396.06 | test_privategw_acl.py
test_01_vpc_privategw_acl | Success | 77.18 | test_privategw_acl.py
test_01_primary_storage_nfs | Success | 35.76 | test_primary_storage.py
test_createPortablePublicIPRange | Success | 15.13 | test_portable_publicip.py
test_createPortablePublicIPAcquire | Success | 15.33 | test_portable_publicip.py
test_isolate_network_password_server | Success | 59.85 | test_password_server.py
test_UpdateStorageOverProvisioningFactor | Success | 0.10 | test_over_provisioning.py
test_oobm_zchange_password | Success | 25.45 | test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership | Success | 16.26 | test_outofbandmanagement.py
test_oobm_issue_power_status | Success | 10.18 | test_outofbandmanagement.py
test_oobm_issue_power_soft | Success | 15.26 | test_outofbandmanagement.py
test_oobm_issue_power_reset | Success | 10.23 | test_outofbandmanagement.py
test_oobm_issue_power_on | Success | 15.24 | test_outofbandmanagement.py
test_oobm_issue_power_off | Success | 10.34 | test_outofbandmanagement.py
test_oobm_issue_power_cycle | Success | 15.28 | test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones | Success | 82.50 | test_outofbandmanagement.py
test_oobm_enable_feature_valid | Success | 5.13 | test_outofbandmanagement.py
test_oobm_enable_feature_invalid | Success | 0.08 | test_outofbandmanagement.py
test_oobm_disable_feature_valid | Success | 0.15 | test_outofbandmanagement.py
test_oobm_disable_feature_invalid | Success | 0.08 | test_outofbandmanagement.py
test_oobm_configure_invalid_driver | Success | 0.07 | test_outofbandmanagement.py
test_oobm_configure_default_driver | Success | 0.06 | test_outofbandmanagement.py
test_oobm_background_powerstate_sync | Success | 29.34 | test_outofbandmanagement.py
test_extendPhysicalNetworkVlan | Success | 15.25 | test_non_contigiousvlan.py
test_01_nic | Success | 555.53 | test_nic.py
test_releaseIP | Success | 152.30 | test_network.py
test_reboot_router | Success | 438.61 | test_network.py
test_public_ip_user_account | Success | 10.36 | test_network.py
test_public_ip_admin_account | Success | 40.27 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 66.54 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.42 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 123.77 | test_network.py
test_delete_account | Success | 298.52 | test_network.py
test_02_port_fwd_on_non_src_nat | Success | 55.50 | test_network.py
test_01_port_fwd_on_src_nat | Success | 111.72 | test_network.py
test_nic_secondaryip_add_remove | Success | 212.51 | test_multipleips_per_nic.py
login_test_saml_user | Success | 21.45 | test_login.py
test_assign_and_removal_lb | Success | 133.02 | test_loadbalance.py
test_02_create_lb_rule_non_nat | Success | 186.97 | test_loadbalance.py
test_01_create_lb_rule_src_nat | Success | 228.66 | test_loadbalance.py
test_03_list_snapshots | Success | 0.06 | test_list_ids_parameter.py
test_02_list_templates | Success | 0.03 | test_list_ids_parameter.py
test_01_list_volumes | Success | 0.02 | test_list_ids_parameter.py
test_07_list_default_iso | Success | 0.06 | test_iso.py
test_05_iso_permissions | Success | 0.11 | test_iso.py
test_04_extract_Iso | Success | 5.25 | test_iso.py
test_03_delete_iso | Success | 95.10 | test_iso.py
test_02_edit_iso | Success | 0.06 | test_iso.py
test_01_create_iso | Success | 21.32 | test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 273.42 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 192.81 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 569.57 | test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 443.49 | test_internal_lb.py
test_dedicateGuestVlanRange | Success | 10.20 | test_guest_vlan_range.py
test_UpdateConfigParamWithScope | Success | 0.11 | test_global_settings.py
test_rolepermission_lifecycle_update | Success | 6.43 | test_dynamicroles.py
test_rolepermission_lifecycle_list | Success | 6.35 | test_dynamicroles.py
test_rolepermission_lifecycle_delete | Success | 6.19 | test_dynamicroles.py
test_rolepermission_lifecycle_create | Success | 6.21 | test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updates | Success | 6.29 | test_dynamicroles.py
test_role_lifecycle_update_role_inuse | Success | 6.20 | test_dynamicroles.py
test_role_lifecycle_update | Success | 11.26 | test_dynamicroles.py
test_role_lifecycle_list | Success | 6.29 | test_dynamicroles.py
test_role_lifecycle_delete | Success | 6.21 | test_dynamicroles.py
test_role_lifecycle_create | Success | 6.34 | test_dynamicroles.py
test_role_inuse_deletion | Success | 6.27 | test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers | Success | 7.52 | test_dynamicroles.py
test_role_account_acls | Success | 7.82 | test_dynamicroles.py
test_default_role_deletion | Success | 6.27 | test_dynamicroles.py
test_04_create_fat_type_disk_offering | Success | 0.06 | test_disk_offerings.py
test_03_delete_disk_offering | Success | 0.03 | test_disk_offerings.py
test_02_edit_disk_offering | Success | 0.04 | test_disk_offerings.py
test_02_create_sparse_type_disk_offering | Success | 0.05 | test_disk_offerings.py
test_01_create_disk_offering | Success | 0.08 | test_disk_offerings.py
test_deployvm_userdispersing | Success | 20.39 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated | Success | 15.38 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit | Success | 115.78 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post | Success | 10.32 | test_deploy_vm_with_userdata.py
test_deployvm_userdata | Success | 45.53 | test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize | Success | 6.26 | test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize | Success | 6.24 | test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize | Success | 243.00 | test_deploy_vm_root_resize.py
test_deploy_vm_from_iso | Success | 227.94 | test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroup | Success | 121.38 | test_affinity_groups.py
test_03_delete_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_01_test_vm_volume_snapshot | Skipped | 0.00 | test_vm_snapshots.py
test_01_create_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_06_copy_template | Skipped | 0.00 | test_templates.py
test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
test_01_primary_storage_iscsi | Skipped | 0.03 | test_primary_storage.py
test_nested_virtualization_vmware | Skipped | 0.00 | test_nested_virtualization.py
test_06_copy_iso | Skipped | 0.00 | test_iso.py
test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---