You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Kishor Gollapalliwar <ki...@gmail.com> on 2020/01/14 04:41:53 UTC

Review Request 71992: RANGER-2695: Default displayName for ServiceDef

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71992/
-----------------------------------------------------------

Review request for ranger, Jayendra Parab, Mehul Parikh, and Pradeep Agrawal.


Bugs: RANGER-2695
    https://issues.apache.org/jira/browse/RANGER-2695


Repository: ranger


Description
-------

Ranger creates ServiceDef(s) as part of initial setup. While creating these ServiceDef(s) it refers respective JSON file. If display name for a ServiceDef is not provided OR it is empty, ServiceDef's name should be used as DEFAULT displayName for that ServiceDef.


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java e96f881ac 


Diff: https://reviews.apache.org/r/71992/diff/1/


Testing
-------

Setup Ranger using following scenarios:
 1. No displayName attribute in JSON file.
 2. displayName attribute with empty string.
 3. displayName attribute with string other than name.


Thanks,

Kishor Gollapalliwar


Re: Review Request 71992: RANGER-2695: Default displayName for ServiceDef

Posted by Kishor Gollapalliwar <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71992/
-----------------------------------------------------------

(Updated Jan. 14, 2020, 5:34 a.m.)


Review request for ranger, Jayendra Parab, Mehul Parikh, and Pradeep Agrawal.


Changes
-------

Added null check


Bugs: RANGER-2695
    https://issues.apache.org/jira/browse/RANGER-2695


Repository: ranger


Description
-------

Ranger creates ServiceDef(s) as part of initial setup. While creating these ServiceDef(s) it refers respective JSON file. If display name for a ServiceDef is not provided OR it is empty, ServiceDef's name should be used as DEFAULT displayName for that ServiceDef.


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java e96f881ac 


Diff: https://reviews.apache.org/r/71992/diff/2/

Changes: https://reviews.apache.org/r/71992/diff/1-2/


Testing
-------

Setup Ranger using following scenarios:
 1. No displayName attribute in JSON file.
 2. displayName attribute with empty string.
 3. displayName attribute with string other than name.


Thanks,

Kishor Gollapalliwar