You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/08/18 21:02:32 UTC
[GitHub] [hive] saihemanth-cloudera opened a new pull request #1411: Hive24048
saihemanth-cloudera opened a new pull request #1411:
URL: https://github.com/apache/hive/pull/1411
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Jackson version upgrade in hive
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
To avoid conflicts caused by version mismatche
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
No
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
Local Machine and Unit tests
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] risdenk commented on a change in pull request #1411: Hive24048
Posted by GitBox <gi...@apache.org>.
risdenk commented on a change in pull request #1411:
URL: https://github.com/apache/hive/pull/1411#discussion_r478680036
##########
File path: pom.xml
##########
@@ -149,7 +149,7 @@
<httpcomponents.client.version>4.5.6</httpcomponents.client.version>
<httpcomponents.core.version>4.4.10</httpcomponents.core.version>
<ivy.version>2.4.0</ivy.version>
- <jackson.version>2.10.0</jackson.version>
+ <jackson.version>2.10.3</jackson.version>
Review comment:
Small nit - not sure why 2.10.3 was chosen - but 2.10.5 is out - this would address any issues w/ snakeyaml <1.26 which is pulled in by `jackson-dataformat-yaml` - this was fixed in 2.10.4+.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] yongzhi commented on a change in pull request #1411: Hive24048
Posted by GitBox <gi...@apache.org>.
yongzhi commented on a change in pull request #1411:
URL: https://github.com/apache/hive/pull/1411#discussion_r477405351
##########
File path: pom.xml
##########
@@ -659,9 +659,14 @@
<artifactId>jackson-dataformat-smile</artifactId>
<version>${jackson.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.dataformat</groupId>
+ <artifactId>jackson-dataformat-yaml</artifactId>
+ <version>${jackson.version}</version>
+ </dependency>
<dependency>
<groupId>com.fasterxml.jackson.jaxrs</groupId>
- <artifactId>jackson-jaxrs-json-provider</artifactId>
+ <artifactId>jackson-jaxrs-base</artifactId>
Review comment:
It seems that you have not changed this pom yet: https://github.com/apache/hive/blob/master/testutils/ptest2/pom.xml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] yongzhi commented on a change in pull request #1411: Hive24048
Posted by GitBox <gi...@apache.org>.
yongzhi commented on a change in pull request #1411:
URL: https://github.com/apache/hive/pull/1411#discussion_r475866169
##########
File path: pom.xml
##########
@@ -659,9 +659,14 @@
<artifactId>jackson-dataformat-smile</artifactId>
<version>${jackson.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.dataformat</groupId>
+ <artifactId>jackson-dataformat-yaml</artifactId>
+ <version>${jackson.version}</version>
+ </dependency>
<dependency>
<groupId>com.fasterxml.jackson.jaxrs</groupId>
- <artifactId>jackson-jaxrs-json-provider</artifactId>
+ <artifactId>jackson-jaxrs-base</artifactId>
Review comment:
Why not use jackson-jaxrs-json-provider any longer?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] saihemanth-cloudera commented on a change in pull request #1411: Hive24048
Posted by GitBox <gi...@apache.org>.
saihemanth-cloudera commented on a change in pull request #1411:
URL: https://github.com/apache/hive/pull/1411#discussion_r476591285
##########
File path: pom.xml
##########
@@ -659,9 +659,14 @@
<artifactId>jackson-dataformat-smile</artifactId>
<version>${jackson.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.dataformat</groupId>
+ <artifactId>jackson-dataformat-yaml</artifactId>
+ <version>${jackson.version}</version>
+ </dependency>
<dependency>
<groupId>com.fasterxml.jackson.jaxrs</groupId>
- <artifactId>jackson-jaxrs-json-provider</artifactId>
+ <artifactId>jackson-jaxrs-base</artifactId>
Review comment:
In the Jira, it was mentioned that jackson-jaxrs-base version needs to be updated and jackson-jaxrs-json-provider comes in the jackson-jaxrs-base library. So that's why I used jackson-jaxrs-base.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk closed pull request #1411: Hive24048
Posted by GitBox <gi...@apache.org>.
kgyrtkirk closed pull request #1411:
URL: https://github.com/apache/hive/pull/1411
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] risdenk commented on a change in pull request #1411: Hive24048
Posted by GitBox <gi...@apache.org>.
risdenk commented on a change in pull request #1411:
URL: https://github.com/apache/hive/pull/1411#discussion_r477404084
##########
File path: pom.xml
##########
@@ -659,9 +659,14 @@
<artifactId>jackson-dataformat-smile</artifactId>
<version>${jackson.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.dataformat</groupId>
+ <artifactId>jackson-dataformat-yaml</artifactId>
+ <version>${jackson.version}</version>
+ </dependency>
<dependency>
<groupId>com.fasterxml.jackson.jaxrs</groupId>
- <artifactId>jackson-jaxrs-json-provider</artifactId>
+ <artifactId>jackson-jaxrs-base</artifactId>
Review comment:
Instead of calling out all of the Jackson dependencies separately in the top level pom, there is a Jackson BOM that should help with this.
https://github.com/FasterXML/jackson-bom
specifically add to the dependency management section in the top level pom:
```
<dependency>
<groupId>com.fasterxml.jackson</groupId>
<artifactId>jackson-bom</artifactId>
<version>${jackson.version}</version>
<scope>import</scope>
<type>pom</type>
</dependency>
```
This will ensure all the Jackson dependencies are the right version. This should avoid even having to declare all the individual jackson dependencies in the top level pom w/ versions.
PS - you can do the same with Spring and Netty. There are a few other projects that produce BOM artifacts to specifically help with this .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org