You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2017/02/06 06:21:29 UTC

[GitHub] spark pull request #16726: [SPARK-19390][SQL] Replace the unnecessary usages...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16726#discussion_r99522843
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveTableScanSuite.scala ---
    @@ -166,13 +166,11 @@ class HiveTableScanSuite extends HiveComparisonTest with SQLTestUtils with TestH
                  |PARTITION (p1='a',p2='c',p3='c',p4='d',p5='e')
                  |SELECT v.id
                """.stripMargin)
    -        val plan = sql(
    -          s"""
    -             |SELECT * FROM $table
    -           """.stripMargin).queryExecution.sparkPlan
    +        val plan = sql(s"SELECT * FROM $table").queryExecution.sparkPlan
             val relation = plan.collectFirst {
               case p: HiveTableScanExec => p.relation
             }.get
    +        // This test case is to verify `hiveQlTable` and `getHiveQlPartitions()`
             val tableCols = relation.hiveQlTable.getCols
    --- End diff --
    
    can we remove `hiveQlTable` now?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org