You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@whirr.apache.org by Andrei Savu <sa...@gmail.com> on 2012/01/21 01:25:36 UTC

Two more patches on the way

Hey guys,

Here are two more patches awaiting a review:

https://issues.apache.org/jira/browse/WHIRR-483  (just a version change)
https://issues.apache.org/jira/browse/WHIRR-479  (a bit more complicated)

Next thing for me is to work on Hadoop start / stop / cleanup scripts.

Akash any updates on HBase?

Cheers,

-- Andrei Savu / andreisavu.ro

Re: Two more patches on the way

Posted by Lars George <la...@gmail.com>.

Great, thanks!

On Jan 24, 2012, at 7:33 PM, Andrei Savu wrote:

> Thanks Lars for reviewing. Unit & integration tests work fine for me. I
> will go ahead and commit this tomorrow.
> 
> -- Andrei Savu
> 
> On Wed, Jan 25, 2012 at 2:23 AM, Lars George <la...@gmail.com> wrote:
> 
>> Hi Andrei,
>> 
>> I did not run the tests but did a code review. What I can see it looks
>> great. So as long as the tests pass for you I am +1.
>> 
>> Lars
>> 
>> On Jan 24, 2012, at 6:16 AM, Andrei Savu wrote:
>> 
>>> Anyone has some time to review them?
>>> 
>>> On Sat, Jan 21, 2012 at 2:25 AM, Andrei Savu <sa...@gmail.com>
>> wrote:
>>> 
>>>> Hey guys,
>>>> 
>>>> Here are two more patches awaiting a review:
>>>> 
>>>> https://issues.apache.org/jira/browse/WHIRR-483  (just a version
>> change)
>>>> https://issues.apache.org/jira/browse/WHIRR-479  (a bit more
>> complicated)
>>>> 
>>>> Next thing for me is to work on Hadoop start / stop / cleanup scripts.
>>>> 
>>>> Akash any updates on HBase?
>>>> 
>>>> Cheers,
>>>> 
>>>> -- Andrei Savu / andreisavu.ro
>>>> 
>>>> 
>> 
>>

Re: Two more patches on the way

Posted by Andrei Savu <sa...@gmail.com>.

Thanks Lars for reviewing. Unit & integration tests work fine for me. I
will go ahead and commit this tomorrow.

-- Andrei Savu

On Wed, Jan 25, 2012 at 2:23 AM, Lars George <la...@gmail.com> wrote:

> Hi Andrei,
>
> I did not run the tests but did a code review. What I can see it looks
> great. So as long as the tests pass for you I am +1.
>
> Lars
>
> On Jan 24, 2012, at 6:16 AM, Andrei Savu wrote:
>
> > Anyone has some time to review them?
> >
> > On Sat, Jan 21, 2012 at 2:25 AM, Andrei Savu <sa...@gmail.com>
> wrote:
> >
> >> Hey guys,
> >>
> >> Here are two more patches awaiting a review:
> >>
> >> https://issues.apache.org/jira/browse/WHIRR-483  (just a version
> change)
> >> https://issues.apache.org/jira/browse/WHIRR-479  (a bit more
> complicated)
> >>
> >> Next thing for me is to work on Hadoop start / stop / cleanup scripts.
> >>
> >> Akash any updates on HBase?
> >>
> >> Cheers,
> >>
> >> -- Andrei Savu / andreisavu.ro
> >>
> >>
>
>

Re: Two more patches on the way

Posted by Lars George <la...@gmail.com>.

Hi Andrei,

I did not run the tests but did a code review. What I can see it looks great. So as long as the tests pass for you I am +1.

Lars

On Jan 24, 2012, at 6:16 AM, Andrei Savu wrote:

> Anyone has some time to review them?
> 
> On Sat, Jan 21, 2012 at 2:25 AM, Andrei Savu <sa...@gmail.com> wrote:
> 
>> Hey guys,
>> 
>> Here are two more patches awaiting a review:
>> 
>> https://issues.apache.org/jira/browse/WHIRR-483  (just a version change)
>> https://issues.apache.org/jira/browse/WHIRR-479  (a bit more complicated)
>> 
>> Next thing for me is to work on Hadoop start / stop / cleanup scripts.
>> 
>> Akash any updates on HBase?
>> 
>> Cheers,
>> 
>> -- Andrei Savu / andreisavu.ro
>> 
>>

Re: Two more patches on the way

Posted by Andrei Savu <sa...@gmail.com>.

Anyone has some time to review them?

On Sat, Jan 21, 2012 at 2:25 AM, Andrei Savu <sa...@gmail.com> wrote:

> Hey guys,
>
> Here are two more patches awaiting a review:
>
> https://issues.apache.org/jira/browse/WHIRR-483  (just a version change)
> https://issues.apache.org/jira/browse/WHIRR-479  (a bit more complicated)
>
> Next thing for me is to work on Hadoop start / stop / cleanup scripts.
>
> Akash any updates on HBase?
>
> Cheers,
>
> -- Andrei Savu / andreisavu.ro
>
>