You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Chris Douglas (JIRA)" <ji...@apache.org> on 2008/09/25 00:59:44 UTC
[jira] Created: (HADOOP-4269) LineRecordReader.LineReader should
use util.LineReader
LineRecordReader.LineReader should use util.LineReader
------------------------------------------------------
Key: HADOOP-4269
URL: https://issues.apache.org/jira/browse/HADOOP-4269
Project: Hadoop Core
Issue Type: Bug
Components: mapred, util
Affects Versions: 0.19.0
Reporter: Chris Douglas
LineRecordReader.LineReader was moved to util and removed from the mapreduce package, but its implementation remains in mapred.LineRecordReader. It would be better if this used the implementation in util.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4269) LineRecordReader.LineReader should
use util.LineReader
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-4269:
----------------------------------
Attachment: 4269-0.patch
Replaced LineRecordReader.LineReader with empty subclass of the one in util, made package-private constructor public (should have no other users in util), and added an InputStream cstr using the default. Also updated test cases and other users of LineReader.
> LineRecordReader.LineReader should use util.LineReader
> ------------------------------------------------------
>
> Key: HADOOP-4269
> URL: https://issues.apache.org/jira/browse/HADOOP-4269
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred, util
> Affects Versions: 0.19.0
> Reporter: Chris Douglas
> Fix For: 0.19.0
>
> Attachments: 4269-0.patch
>
>
> LineRecordReader.LineReader was moved to util and removed from the mapreduce package, but its implementation remains in mapred.LineRecordReader. It would be better if this used the implementation in util.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4269) LineRecordReader.LineReader should
use util.LineReader
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-4269:
----------------------------------
Fix Version/s: 0.19.0
Assignee: Chris Douglas
Status: Patch Available (was: Open)
> LineRecordReader.LineReader should use util.LineReader
> ------------------------------------------------------
>
> Key: HADOOP-4269
> URL: https://issues.apache.org/jira/browse/HADOOP-4269
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred, util
> Affects Versions: 0.19.0
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Fix For: 0.19.0
>
> Attachments: 4269-0.patch
>
>
> LineRecordReader.LineReader was moved to util and removed from the mapreduce package, but its implementation remains in mapred.LineRecordReader. It would be better if this used the implementation in util.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4269) LineRecordReader.LineReader should
use util.LineReader
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-4269:
----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Chris!
> LineRecordReader.LineReader should use util.LineReader
> ------------------------------------------------------
>
> Key: HADOOP-4269
> URL: https://issues.apache.org/jira/browse/HADOOP-4269
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred, util
> Affects Versions: 0.19.0
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Fix For: 0.19.0
>
> Attachments: 4269-0.patch
>
>
> LineRecordReader.LineReader was moved to util and removed from the mapreduce package, but its implementation remains in mapred.LineRecordReader. It would be better if this used the implementation in util.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4269) LineRecordReader.LineReader should
use util.LineReader
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634934#action_12634934 ]
Hudson commented on HADOOP-4269:
--------------------------------
Integrated in Hadoop-trunk #615 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/615/])
> LineRecordReader.LineReader should use util.LineReader
> ------------------------------------------------------
>
> Key: HADOOP-4269
> URL: https://issues.apache.org/jira/browse/HADOOP-4269
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred, util
> Affects Versions: 0.19.0
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Fix For: 0.19.0
>
> Attachments: 4269-0.patch
>
>
> LineRecordReader.LineReader was moved to util and removed from the mapreduce package, but its implementation remains in mapred.LineRecordReader. It would be better if this used the implementation in util.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4269) LineRecordReader.LineReader should
use util.LineReader
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634368#action_12634368 ]
Hadoop QA commented on HADOOP-4269:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12390884/4269-0.patch
against trunk revision 698721.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 9 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3366/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3366/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3366/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3366/console
This message is automatically generated.
> LineRecordReader.LineReader should use util.LineReader
> ------------------------------------------------------
>
> Key: HADOOP-4269
> URL: https://issues.apache.org/jira/browse/HADOOP-4269
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred, util
> Affects Versions: 0.19.0
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Fix For: 0.19.0
>
> Attachments: 4269-0.patch
>
>
> LineRecordReader.LineReader was moved to util and removed from the mapreduce package, but its implementation remains in mapred.LineRecordReader. It would be better if this used the implementation in util.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.