You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by wi...@apache.org on 2015/07/27 10:42:54 UTC
[06/50] [abbrv] git commit: updated refs/heads/reporter to 3e1816d
CLOUDSTACK-8581: Do not make attributes final and don't set them to null
Signed-off-by: Wido den Hollander <wi...@widodh.nl>
This closes #582
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/8d96aab9
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/8d96aab9
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/8d96aab9
Branch: refs/heads/reporter
Commit: 8d96aab9b2ee32038d43d13b3d85c6a0c7729ee6
Parents: 4b61f5a
Author: Wido den Hollander <wi...@widodh.nl>
Authored: Thu Jul 16 18:13:46 2015 +0200
Committer: Wido den Hollander <wi...@widodh.nl>
Committed: Fri Jul 17 10:07:04 2015 +0200
----------------------------------------------------------------------
.../api/command/admin/storage/AddS3Cmd.java | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/8d96aab9/api/src/org/apache/cloudstack/api/command/admin/storage/AddS3Cmd.java
----------------------------------------------------------------------
diff --git a/api/src/org/apache/cloudstack/api/command/admin/storage/AddS3Cmd.java b/api/src/org/apache/cloudstack/api/command/admin/storage/AddS3Cmd.java
index 09272a5..d54cb75 100644
--- a/api/src/org/apache/cloudstack/api/command/admin/storage/AddS3Cmd.java
+++ b/api/src/org/apache/cloudstack/api/command/admin/storage/AddS3Cmd.java
@@ -68,28 +68,28 @@ public final class AddS3Cmd extends BaseCmd {
private String secretKey;
@Parameter(name = S3_END_POINT, type = STRING, required = false, description = "S3 host name")
- private final String endPoint = null;
+ private String endPoint;
@Parameter(name = S3_BUCKET_NAME, type = STRING, required = true, description = "name of the template storage bucket")
private String bucketName;
@Parameter(name = S3_HTTPS_FLAG, type = BOOLEAN, required = false, description = "connect to the S3 endpoint via HTTPS?")
- private final Boolean httpsFlag = null;
+ private Boolean httpsFlag;
@Parameter(name = S3_CONNECTION_TIMEOUT, type = INTEGER, required = false, description = "connection timeout (milliseconds)")
- private final Integer connectionTimeout = null;
+ private Integer connectionTimeout;
@Parameter(name = S3_MAX_ERROR_RETRY, type = INTEGER, required = false, description = "maximum number of times to retry on error")
- private final Integer maxErrorRetry = null;
+ private Integer maxErrorRetry;
@Parameter(name = S3_SOCKET_TIMEOUT, type = INTEGER, required = false, description = "socket timeout (milliseconds)")
- private final Integer socketTimeout = null;
+ private Integer socketTimeout;
@Parameter(name = S3_CONNECTION_TTL, type = INTEGER, required = false, description = "connection ttl (milliseconds)")
- private final Integer connectionTtl = null;
+ private Integer connectionTtl;
@Parameter(name = S3_USE_TCP_KEEPALIVE, type = BOOLEAN, required = false, description = "whether tcp keepalive is used")
- private final Boolean useTCPKeepAlive = null;
+ private Boolean useTCPKeepAlive;
@Override
public void execute() throws ResourceUnavailableException, InsufficientCapacityException, ServerApiException, ConcurrentOperationException,