You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "tim mcnamara (JIRA)" <ji...@apache.org> on 2008/11/29 13:57:05 UTC
[jira] Created: (CAMEL-1131) Invalid contructor intitialization in
MulticastProcessor
Invalid contructor intitialization in MulticastProcessor
--------------------------------------------------------
Key: CAMEL-1131
URL: https://issues.apache.org/activemq/browse/CAMEL-1131
Project: Apache Camel
Issue Type: Bug
Components: camel-core
Affects Versions: 2.0.0
Reporter: tim mcnamara
Fix For: 2.0.0
parallelProcessing and executor being overridden in constructor.
{code:title=MulticastProcessor.java|borderStyle=solid}
public MulticastProcessor(Collection<Processor> processors, AggregationStrategy aggregationStrategy, boolean parallelProcessing, ThreadPoolExecutor executor) {
this(processors, aggregationStrategy, false, null, false);
}
{code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-1131) Invalid contructor intitialization in
MulticastProcessor
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved CAMEL-1131.
--------------------------------
Fix Version/s: 1.5.1
Resolution: Duplicate
Thanks for reporting. It is a duplicate of CAMEL-1108 and has been fixed in 1.5.1 and 2.0
> Invalid contructor intitialization in MulticastProcessor
> --------------------------------------------------------
>
> Key: CAMEL-1131
> URL: https://issues.apache.org/activemq/browse/CAMEL-1131
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-core
> Affects Versions: 2.0.0
> Reporter: tim mcnamara
> Fix For: 1.5.1, 2.0.0
>
>
> parallelProcessing and executor being overridden in constructor.
> {code:title=MulticastProcessor.java|borderStyle=solid}
> public MulticastProcessor(Collection<Processor> processors, AggregationStrategy aggregationStrategy, boolean parallelProcessing, ThreadPoolExecutor executor) {
> this(processors, aggregationStrategy, false, null, false);
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1131) Invalid contructor intitialization
in MulticastProcessor
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47692#action_47692 ]
Claus Ibsen commented on CAMEL-1131:
------------------------------------
Feel free to submit a unit test for the multicast based on the splitter. We would love that.
Yeah maybe we should add some methods on CamelCountext that will look for a given *Type, either returning the first found, or a list of *Type intances so end users easily can get it instead of all the cumbersome recursive code.
Any thoughts on this? As it will add more methods on the public interface
> Invalid contructor intitialization in MulticastProcessor
> --------------------------------------------------------
>
> Key: CAMEL-1131
> URL: https://issues.apache.org/activemq/browse/CAMEL-1131
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-core
> Affects Versions: 2.0.0
> Reporter: tim mcnamara
>
> parallelProcessing and executor being overridden in constructor.
> {code:title=MulticastProcessor.java|borderStyle=solid}
> public MulticastProcessor(Collection<Processor> processors, AggregationStrategy aggregationStrategy, boolean parallelProcessing, ThreadPoolExecutor executor) {
> this(processors, aggregationStrategy, false, null, false);
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1131) Invalid contructor intitialization
in MulticastProcessor
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47694#action_47694 ]
Claus Ibsen commented on CAMEL-1131:
------------------------------------
I have exposes the executor using a getter. Could you try update the trunk code and see if that helps?
> Invalid contructor intitialization in MulticastProcessor
> --------------------------------------------------------
>
> Key: CAMEL-1131
> URL: https://issues.apache.org/activemq/browse/CAMEL-1131
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-core
> Affects Versions: 2.0.0
> Reporter: tim mcnamara
>
> parallelProcessing and executor being overridden in constructor.
> {code:title=MulticastProcessor.java|borderStyle=solid}
> public MulticastProcessor(Collection<Processor> processors, AggregationStrategy aggregationStrategy, boolean parallelProcessing, ThreadPoolExecutor executor) {
> this(processors, aggregationStrategy, false, null, false);
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1131) Invalid contructor intitialization
in MulticastProcessor
Posted by "tim mcnamara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47690#action_47690 ]
tim mcnamara commented on CAMEL-1131:
-------------------------------------
do not see the fix in either 1.5.1 or 2.0.0
> Invalid contructor intitialization in MulticastProcessor
> --------------------------------------------------------
>
> Key: CAMEL-1131
> URL: https://issues.apache.org/activemq/browse/CAMEL-1131
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-core
> Affects Versions: 2.0.0
> Reporter: tim mcnamara
> Fix For: 1.5.1, 2.0.0
>
>
> parallelProcessing and executor being overridden in constructor.
> {code:title=MulticastProcessor.java|borderStyle=solid}
> public MulticastProcessor(Collection<Processor> processors, AggregationStrategy aggregationStrategy, boolean parallelProcessing, ThreadPoolExecutor executor) {
> this(processors, aggregationStrategy, false, null, false);
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1131) Invalid contructor intitialization
in MulticastProcessor
Posted by "tim mcnamara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47691#action_47691 ]
tim mcnamara commented on CAMEL-1131:
-------------------------------------
Sorry about that, I did not update this morning.
It should be noted that there appears to be no test for this. I was
going to create one using SplitterWithCustomThreadPoolExecutorTest as
a reference, but noticed that this test was using the executor from
the SplitterType to validate and not the SplitterProcessor. It was
not obvious how to get at the MulticastProcessor from the camel context
> Invalid contructor intitialization in MulticastProcessor
> --------------------------------------------------------
>
> Key: CAMEL-1131
> URL: https://issues.apache.org/activemq/browse/CAMEL-1131
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-core
> Affects Versions: 2.0.0
> Reporter: tim mcnamara
>
> parallelProcessing and executor being overridden in constructor.
> {code:title=MulticastProcessor.java|borderStyle=solid}
> public MulticastProcessor(Collection<Processor> processors, AggregationStrategy aggregationStrategy, boolean parallelProcessing, ThreadPoolExecutor executor) {
> this(processors, aggregationStrategy, false, null, false);
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1131) Invalid contructor intitialization
in MulticastProcessor
Posted by "tim mcnamara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47699#action_47699 ]
tim mcnamara commented on CAMEL-1131:
-------------------------------------
We need to be able to get at the underlying processor from the
context, then the getter can be used. How do you get access to the
MulticastProcessor that MulticastType has created?
> Invalid contructor intitialization in MulticastProcessor
> --------------------------------------------------------
>
> Key: CAMEL-1131
> URL: https://issues.apache.org/activemq/browse/CAMEL-1131
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-core
> Affects Versions: 2.0.0
> Reporter: tim mcnamara
>
> parallelProcessing and executor being overridden in constructor.
> {code:title=MulticastProcessor.java|borderStyle=solid}
> public MulticastProcessor(Collection<Processor> processors, AggregationStrategy aggregationStrategy, boolean parallelProcessing, ThreadPoolExecutor executor) {
> this(processors, aggregationStrategy, false, null, false);
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1131) Invalid contructor intitialization
in MulticastProcessor
Posted by "tim mcnamara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47693#action_47693 ]
tim mcnamara commented on CAMEL-1131:
-------------------------------------
It would be trivial to create a multicast test similar to the custom
splitter. The problem is, this test would not expose the multicast
constructor bug as the validation is done against the type and not the
processor (where the problem lies). These tests need to cover both
cases - the problem I ran into, is that there was no obvious way to
get at the executor from the multicast processor.
> Invalid contructor intitialization in MulticastProcessor
> --------------------------------------------------------
>
> Key: CAMEL-1131
> URL: https://issues.apache.org/activemq/browse/CAMEL-1131
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-core
> Affects Versions: 2.0.0
> Reporter: tim mcnamara
>
> parallelProcessing and executor being overridden in constructor.
> {code:title=MulticastProcessor.java|borderStyle=solid}
> public MulticastProcessor(Collection<Processor> processors, AggregationStrategy aggregationStrategy, boolean parallelProcessing, ThreadPoolExecutor executor) {
> this(processors, aggregationStrategy, false, null, false);
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-1131) Invalid contructor intitialization in
MulticastProcessor
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-1131:
-------------------------------
Fix Version/s: (was: 2.0.0)
(was: 1.5.1)
> Invalid contructor intitialization in MulticastProcessor
> --------------------------------------------------------
>
> Key: CAMEL-1131
> URL: https://issues.apache.org/activemq/browse/CAMEL-1131
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-core
> Affects Versions: 2.0.0
> Reporter: tim mcnamara
>
> parallelProcessing and executor being overridden in constructor.
> {code:title=MulticastProcessor.java|borderStyle=solid}
> public MulticastProcessor(Collection<Processor> processors, AggregationStrategy aggregationStrategy, boolean parallelProcessing, ThreadPoolExecutor executor) {
> this(processors, aggregationStrategy, false, null, false);
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.