You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/15 01:51:22 UTC

[GitHub] [apisix-dashboard] LiteSun opened a new issue #1773: Improve the limit-count plugin

LiteSun opened a new issue #1773:
URL: https://github.com/apache/apisix-dashboard/issues/1773


   ## Issue description
   <!-- A clear and concise description of what the issue is. -->
   Because the limit-count document(http://apisix.apache.org/docs/apisix/plugins/limit-count/) does not match the actual jsonchema(https://github.com/apache/apisix/blob/master/apisix/plugins/limit-count.lua#L37), the missing fields need to be filled in.
   
   ## Expected behavior
   <!-- A clear and concise description of what you expected to happen. -->
   
   Fields are consistent with limit-count jsonschema.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on issue #1773: add missing fields for limit-count plugin (redis cluster)

Posted by GitBox <gi...@apache.org>.

iamayushdas commented on issue #1773:
URL: https://github.com/apache/apisix-dashboard/issues/1773#issuecomment-822170645


   @juzhiyuan i think limit-count doc matches the json schema? if i am wrong could you please enlight me up?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1773: Improve the limit-count plugin

Posted by GitBox <gi...@apache.org>.

juzhiyuan commented on issue #1773:
URL: https://github.com/apache/apisix-dashboard/issues/1773#issuecomment-820105998


   related issue #1775 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on issue #1773: add missing fields for limit-count plugin (redis cluster)

Posted by GitBox <gi...@apache.org>.

liuxiran commented on issue #1773:
URL: https://github.com/apache/apisix-dashboard/issues/1773#issuecomment-895000632


   Confirmed:
   
   1. we need to update the doc for `limit-count` according to the lua code:
   `redis_password ` and `redis_timeout ` can be configured both in `redis` policy and `redis-cluster` policy
   now it is not specify in the [doc](http://apisix.apache.org/docs/apisix/plugins/limit-count/#attributes)
   
   2. for current dashboard master branch, the UI form for `limit-count` plugin is already completed, we do not need to update it.
   
   ![image](https://user-images.githubusercontent.com/2561857/128670386-9d13a2d9-b823-4dd8-abbc-84a477051487.png)
   
   ![image](https://user-images.githubusercontent.com/2561857/128670466-32f0975e-d4cc-41c7-a23a-6387312ba7f7.png)
   
   cc @juzhiyuan @LiteSun @iamayushdas 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1773: add missing fields for limit-count plugin (redis cluster)

Posted by GitBox <gi...@apache.org>.

juzhiyuan commented on issue #1773:
URL: https://github.com/apache/apisix-dashboard/issues/1773#issuecomment-895038201


   @liuxiran just to make sure, we could close this issue, and create a doc issue in apisix?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran closed issue #1773: add missing fields for limit-count plugin (redis cluster)

Posted by GitBox <gi...@apache.org>.

liuxiran closed issue #1773:
URL: https://github.com/apache/apisix-dashboard/issues/1773


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran removed a comment on issue #1773: add missing fields for limit-count plugin (redis cluster)

Posted by GitBox <gi...@apache.org>.

liuxiran removed a comment on issue #1773:
URL: https://github.com/apache/apisix-dashboard/issues/1773#issuecomment-894995476


   Confirmed,:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on issue #1773: add missing fields for limit-count plugin (redis cluster)

Posted by GitBox <gi...@apache.org>.

liuxiran commented on issue #1773:
URL: https://github.com/apache/apisix-dashboard/issues/1773#issuecomment-894995561


   Comfirmed:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on issue #1773: add missing fields for limit-count plugin (redis cluster)

Posted by GitBox <gi...@apache.org>.

liuxiran commented on issue #1773:
URL: https://github.com/apache/apisix-dashboard/issues/1773#issuecomment-894995476


   Confirmed,:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on issue #1773: add missing fields for limit-count plugin (redis cluster)

Posted by GitBox <gi...@apache.org>.

liuxiran commented on issue #1773:
URL: https://github.com/apache/apisix-dashboard/issues/1773#issuecomment-895106789


   Yep, close it now
   
   the issue in APISIX: https://github.com/apache/apisix/issues/4781


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1773: add missing fields for limit-count plugin (redis cluster)

Posted by GitBox <gi...@apache.org>.

juzhiyuan commented on issue #1773:
URL: https://github.com/apache/apisix-dashboard/issues/1773#issuecomment-822207515


   Pay attention to redis cluster


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran removed a comment on issue #1773: add missing fields for limit-count plugin (redis cluster)

Posted by GitBox <gi...@apache.org>.

liuxiran removed a comment on issue #1773:
URL: https://github.com/apache/apisix-dashboard/issues/1773#issuecomment-894995561


   Comfirmed:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org