You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/03/02 08:14:39 UTC
[GitHub] [kafka] RivenSun2 opened a new pull request #11830: KAFKA-13694: When the Broker side processes the ProduceRequest, it prints more specific information when the verification record fails.
RivenSun2 opened a new pull request #11830:
URL: https://github.com/apache/kafka/pull/11830
When the Broker side processes the ProduceRequest, it prints more specific information when the verification record fails.
Story JIRA: https://issues.apache.org/jira/browse/KAFKA-13694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] RivenSun2 commented on pull request #11830: KAFKA-13694: When the Broker side processes the ProduceRequest, it prints more specific information when the verification record fails.
Posted by GitBox <gi...@apache.org>.
RivenSun2 commented on pull request #11830:
URL: https://github.com/apache/kafka/pull/11830#issuecomment-1059719813
Hi @guozhangwang
Could you help update the status of the relevant JIRA?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a change in pull request #11830: KAFKA-13694: When the Broker side processes the ProduceRequest, it prints more specific information when the verification record fails.
Posted by GitBox <gi...@apache.org>.
ijuma commented on a change in pull request #11830:
URL: https://github.com/apache/kafka/pull/11830#discussion_r820125170
##########
File path: core/src/main/scala/kafka/log/LogValidator.scala
##########
@@ -571,13 +571,9 @@ private[log] object LogValidator extends Logging {
private def processRecordErrors(recordErrors: Seq[ApiRecordError]): Unit = {
if (recordErrors.nonEmpty) {
val errors = recordErrors.map(_.recordError)
- if (recordErrors.exists(_.apiError == Errors.INVALID_TIMESTAMP)) {
Review comment:
We do we no longer need this special case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang merged pull request #11830: KAFKA-13694: When the Broker side processes the ProduceRequest, it prints more specific information when the verification record fails.
Posted by GitBox <gi...@apache.org>.
guozhangwang merged pull request #11830:
URL: https://github.com/apache/kafka/pull/11830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11830: KAFKA-13694: When the Broker side processes the ProduceRequest, it prints more specific information when the verification record fails.
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11830:
URL: https://github.com/apache/kafka/pull/11830#issuecomment-1059721272
JIRA status updated. Thanks for the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #11830: KAFKA-13694: When the Broker side processes the ProduceRequest, it prints more specific information when the verification record fails.
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #11830:
URL: https://github.com/apache/kafka/pull/11830#issuecomment-1059424145
Looked into the jenkins and they are irrelevant. Merging to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] RivenSun2 commented on pull request #11830: KAFKA-13694: When the Broker side processes the ProduceRequest, it prints more specific information when the verification record fails.
Posted by GitBox <gi...@apache.org>.
RivenSun2 commented on pull request #11830:
URL: https://github.com/apache/kafka/pull/11830#issuecomment-1056534492
Hi @guozhangwang @showuon
please help to review PR when available.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a change in pull request #11830: KAFKA-13694: When the Broker side processes the ProduceRequest, it prints more specific information when the verification record fails.
Posted by GitBox <gi...@apache.org>.
showuon commented on a change in pull request #11830:
URL: https://github.com/apache/kafka/pull/11830#discussion_r820173111
##########
File path: core/src/main/scala/kafka/log/LogValidator.scala
##########
@@ -571,13 +571,9 @@ private[log] object LogValidator extends Logging {
private def processRecordErrors(recordErrors: Seq[ApiRecordError]): Unit = {
if (recordErrors.nonEmpty) {
val errors = recordErrors.map(_.recordError)
- if (recordErrors.exists(_.apiError == Errors.INVALID_TIMESTAMP)) {
Review comment:
Yes, looks like we need this, because we break 2 test cases after removing it. PR to bring it back to fix failed tests is opened: https://github.com/apache/kafka/pull/11853 . Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #11830: KAFKA-13694: When the Broker side processes the ProduceRequest, it prints more specific information when the verification record fails.
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #11830:
URL: https://github.com/apache/kafka/pull/11830#issuecomment-1058837418
Thanks @RivenSun2 , the changes LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org