[GitHub] [incubator-zipkin] adriancole commented on a change in pull request #2580: Makes it an error to store during assembly of a call

[GitBox <gi...@apache.org>]

adriancole commented on a change in pull request #2580: Makes it an error to store during assembly of a call
URL: https://github.com/apache/incubator-zipkin/pull/2580#discussion_r282822071
 
 

 ##########
 File path: zipkin-server/src/main/java/zipkin2/server/internal/throttle/ThrottledCall.java
 ##########
 @@ -41,39 +39,21 @@
  *
  * @see ThrottledStorageComponent
  */
-final class ThrottledCall<V> extends Call<V> {
+final class ThrottledCall<V> extends Call.Base<V> {
   final ExecutorService executor;
   final Limiter<Void> limiter;
-  final Listener limitListener;
-  /**
-   * supplier call needs to be supplied later to avoid having it take action when it is created
-   * (like {@link InMemoryStorage} and thus avoid being throttled.
-   */
-  final Supplier<? extends Call<V>> supplier;
-  volatile Call<V> delegate;
-  volatile boolean canceled;
-
-  public ThrottledCall(ExecutorService executor, Limiter<Void> limiter,
-    Supplier<? extends Call<V>> supplier) {
+  final Call<V> delegate;
 
 Review comment:
   look ma. no volatiles :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services