You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Wilder Rodrigues <wr...@schubergphilis.com> on 2014/02/13 12:41:42 UTC
Review Request 18070: Fixing 12 scary from the engine-storage-volume module
found by FindBugs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18070/
-----------------------------------------------------------
Review request for cloudstack, daan Hoogland and Hugo Trippaers.
Repository: cloudstack-git
Description
-------
Fixing 12 scary from the engine-storage-volume module. All the issues were related to passing null to methods that expect a non-null parameter and also methods passing wrong types.
Diffs
-----
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java 3e315da
Diff: https://reviews.apache.org/r/18070/diff/
Testing
-------
Build passed succesfully
Thanks,
Wilder Rodrigues
Re: Review Request 18070: Fixing 12 scary from the engine-storage-volume
module found by FindBugs
Posted by Wilder Rodrigues <wr...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18070/
-----------------------------------------------------------
(Updated Feb. 13, 2014, 12:07 p.m.)
Review request for cloudstack, daan Hoogland and Hugo Trippaers.
Changes
-------
Adding branch
Repository: cloudstack-git
Description
-------
Fixing 12 scary from the engine-storage-volume module. All the issues were related to passing null to methods that expect a non-null parameter and also methods passing wrong types.
Diffs
-----
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java 3e315da
Diff: https://reviews.apache.org/r/18070/diff/
Testing
-------
Build passed succesfully
Thanks,
Wilder Rodrigues