[jira] [Commented] (HADOOP-14089) Shaded Hadoop client runtime includes non-shaded classes

["Andrew Wang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113700#comment-16113700 ] 

Andrew Wang commented on HADOOP-14089:
--------------------------------------

This looks fine to me too. Is it expected that the build fails with the patch applied? It's flagging some javax, okio, microsoft files, among others.

> Shaded Hadoop client runtime includes non-shaded classes
> --------------------------------------------------------
>
>                 Key: HADOOP-14089
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14089
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: 3.0.0-alpha2
>            Reporter: David Phillips
>            Assignee: Sean Busbey
>            Priority: Critical
>         Attachments: HADOOP-14089.WIP.0.patch
>
>
> The jar includes things like {{assets}}, {{okio}}, {{javax/annotation}}, {{javax/ws}}, {{mozilla}}, etc.
> An easy way to verify this is to look at the contents of the jar:
> {code}
> jar tf hadoop-client-runtime-xxx.jar | sort | grep -v '^org/apache/hadoop'
> {code}
> For standard dependencies, such as the JSR 305 {{javax.annotation}} or JAX-RS {{javax.ws}}, it makes sense for those to be normal dependencies in the POM -- they are standard, so version conflicts shouldn't be a problem. The JSR 305 annotations can be {{<optional>true</optional>}} since they aren't needed at runtime (this is what Guava does).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org