Tiles:insert should have default "flush" to false on JSP1.2+

[Nicolas De Loof <ni...@cgey.com>]

Hello,

<tiles:inert> tag does a flush before doing includes, conforming to JSP 1.1.

On JSP1.2+ container, this is not mandatory anymore, and not flushing may
allow to use this tag inside body of other JSP tags. Notice default JSP1.2
<jsp:include> flush attribute is "false".


folowwing
http://nagoya.apache.org/eyebrowse/ReadMsg?listName=struts-user@jakarta.apac
he.org&msgNo=60764 , here is a proposal update for
org.apache.struts.taglib.tiles.InsertTag

adding :

    protected static boolean defaultFlush;
    static {
        javax.servlet.jsp.JspEngineInfo engineInfo =
            JspFactory.getDefaultFactory().getEngineInfo();

        // defaultFlush is set to "true" for JSP1.1 containers
        defaultFlush =
engineInfo.getSpecificationVersion().startsWith("1.1");
    }

updating :
-     protected boolean flush = true;
+     protected boolean flush = defaultFlush;


     public void release() {
      super.release();
      attribute = null;
      beanName = null;
      beanProperty = null;
      beanScope = null;

      definitionName = null;
-     flush = true;
+     flush = defaultFlush;
      name = null;
      page = null;
      role = null;
      isErrorIgnored = false;
     }

Nico.


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>