You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Fabien <sv...@coelho.net> on 2015/12/12 10:26:52 UTC

configurable pre-commit script

Hello svn-dev,

I've developped a while back a configurable pre-commit script which we 
have been using in production on several repositories for some years, see:

 	http://www.coelho.net/svn-pre-commit.html

I would be willing to add this script to the subversion code base. I could 
commit it to "contrib/hook-scripts" if I'm given the go (I'm a committer 
in Apache & Subversion).

Any thoughts?

-- 
Fabien.

Re: configurable pre-commit script

Posted by Fabien <sv...@coelho.net>.
>>> This leaves the tools/ directory, but this can only contain APLv2 licenced
>>> code. If you're willing to relience from GPLv3 to APLv2, I see no problem
>>> adding your script somewhere under the tools/hook-scripts/ directory.
>>
>> I'm fine with changing the license to Apache. I'll do that & commit in 
>> a few days if no one complains in between.
>
> Great, thank you!
>
> Perhaps you should choose a name for the subdirectory of your hook
> script in advance and mention it here. Just in case somebody ends
> up objecting the whatever name you choose.

Hmmm... It is just one standalone file which include script & config & 
doc, I would put it directly as "tools/hook-scripts/svn-pre-commit.pl"... 
or something else if a better idea is suggested.

-- 
Fabien

Re: configurable pre-commit script

Posted by Stefan Sperling <st...@elego.de>.
On Sat, Dec 12, 2015 at 08:59:33PM +0100, Fabien wrote:
> 
> Hello Stefan.
> 
> >Your script looks very nice! This definitely saves many people some
> >work in writing their own checks.
> >
> >We're trying to retire the contrib/ directory, since there are several
> >ways of hosting open source add-on scripts elsewhere these days.
> 
> Ok, so not it contrib/.
> 
> >This leaves the tools/ directory, but this can only contain APLv2 licenced
> >code. If you're willing to relience from GPLv3 to APLv2, I see no problem
> >adding your script somewhere under the tools/hook-scripts/ directory.
> 
> I'm fine with changing the license to Apache. I'll do that & commit in a few
> days if no one complains in between.

Great, thank you!

Perhaps you should choose a name for the subdirectory of your hook
script in advance and mention it here. Just in case somebody ends
up objecting the whatever name you choose.

Re: configurable pre-commit script

Posted by Fabien <sv...@coelho.net>.
Hello Stefan.

> Your script looks very nice! This definitely saves many people some
> work in writing their own checks.
>
> We're trying to retire the contrib/ directory, since there are several
> ways of hosting open source add-on scripts elsewhere these days.

Ok, so not it contrib/.

> This leaves the tools/ directory, but this can only contain APLv2 licenced
> code. If you're willing to relience from GPLv3 to APLv2, I see no problem
> adding your script somewhere under the tools/hook-scripts/ directory.

I'm fine with changing the license to Apache. I'll do that & commit in a 
few days if no one complains in between.

-- 
Fabien.

Re: configurable pre-commit script

Posted by Stefan Sperling <st...@elego.de>.
On Sat, Dec 12, 2015 at 10:26:52AM +0100, Fabien wrote:
> 
> Hello svn-dev,
> 
> I've developped a while back a configurable pre-commit script which we have
> been using in production on several repositories for some years, see:
> 
> 	http://www.coelho.net/svn-pre-commit.html
> 
> I would be willing to add this script to the subversion code base. I could
> commit it to "contrib/hook-scripts" if I'm given the go (I'm a committer in
> Apache & Subversion).
> 
> Any thoughts?
> 
> -- 
> Fabien.

Hi Fabien,

Your script looks very nice! This definitely saves many people some
work in writing their own checks.

We're trying to retire the contrib/ directory, since there are several
ways of hosting open source add-on scripts elsewhere these days.

This leaves the tools/ directory, but this can only contain APLv2 licenced
code. If you're willing to relience from GPLv3 to APLv2, I see no problem
adding your script somewhere under the tools/hook-scripts/ directory.
If you're unwilling to change the licence, we can endorse your script by
recommending it to users but we cannot ship it in Subversion releases.