You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Thomas Marshall <tw...@gmail.com> on 2013/08/18 00:03:43 UTC
Review Request 13629: Fix a bug in Value::Set <=
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13629/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
There was a typo in the implementation of the <= operator for Value::Set that unfortunately wasn't being caught by the test. I fixed the typo and modified the test to prevent regressions.
Diffs
-----
src/common/values.cpp 019657e
src/tests/resources_tests.cpp 02d474b
Diff: https://reviews.apache.org/r/13629/diff/
Testing
-------
make check
Thanks,
Thomas Marshall
Re: Review Request 13629: Fix a bug in Value::Set <=
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13629/#review25302
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Aug. 17, 2013, 10:03 p.m., Thomas Marshall wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13629/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2013, 10:03 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> There was a typo in the implementation of the <= operator for Value::Set that unfortunately wasn't being caught by the test. I fixed the typo and modified the test to prevent regressions.
>
>
> Diffs
> -----
>
> src/common/values.cpp 019657e
> src/tests/resources_tests.cpp 02d474b
>
> Diff: https://reviews.apache.org/r/13629/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Thomas Marshall
>
>
Re: Review Request 13629: Fix a bug in Value::Set <=
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13629/#review25276
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Aug. 17, 2013, 10:03 p.m., Thomas Marshall wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13629/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2013, 10:03 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> There was a typo in the implementation of the <= operator for Value::Set that unfortunately wasn't being caught by the test. I fixed the typo and modified the test to prevent regressions.
>
>
> Diffs
> -----
>
> src/common/values.cpp 019657e
> src/tests/resources_tests.cpp 02d474b
>
> Diff: https://reviews.apache.org/r/13629/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Thomas Marshall
>
>