[jira] [Commented] (SCB-1047) microservice.yaml service_description.version support format xxx.xx.xxx.xxx

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SCB-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16706739#comment-16706739 ] 

ASF GitHub Bot commented on SCB-1047:
-------------------------------------

wujimin commented on a change in pull request #1013: [SCB-1047]microservice.yaml  service_description.version support form…
URL: https://github.com/apache/servicecomb-java-chassis/pull/1013#discussion_r238156487
 
 

 ##########
 File path: service-registry/src/main/java/org/apache/servicecomb/serviceregistry/version/Version.java
 ##########
 @@ -23,35 +23,44 @@
 
 // short version is enough
 public class Version implements Comparable<Version> {
-  private static final String[] ZERO = new String[] {"0", "0", "0"};
+  private static final String[] ZERO = new String[] {"0", "0", "0", "0"};
 
   private final short major;
 
   private final short minor;
 
   private final short patch;
 
+  private final short build;
+
+  private final boolean versionFour;
 
 Review comment:
   why need a flag versionFour?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> microservice.yaml  service_description.version support format xxx.xx.xxx.xxx
> ----------------------------------------------------------------------------
>
>                 Key: SCB-1047
>                 URL: https://issues.apache.org/jira/browse/SCB-1047
>             Project: Apache ServiceComb
>          Issue Type: Improvement
>          Components: Java-Chassis
>            Reporter: 何一乐
>            Assignee: 何一乐
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)