[GitHub] [arrow] kou commented on a change in pull request #12489: ARROW-15692: [Dev] Update release scripts to use default branch

[GitBox <gi...@apache.org>]

kou commented on a change in pull request #12489:
URL: https://github.com/apache/arrow/pull/12489#discussion_r817147239



##########
File path: dev/release/post-13-msys2.sh
##########
@@ -45,10 +45,13 @@ if ! git remote | grep -q '^upstream$'; then
   exit 1
 fi
 
+SOURCE_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
+source "${SOURCE_DIR}/git-vars.sh"
+
 echo "Updating repository: ${repository}"
 git fetch --all --prune --tags --force -j$(nproc)
-git checkout master
-git rebase upstream/master
+git checkout ${DEFAULT_BRANCH}
+git rebase upstream/${DEFAULT_BRANCH}

Review comment:
       We should not change this because the repository is the a of msys2/MINGW-packages not apache/arrow.

##########
File path: dev/release/post-14-homebrew.sh
##########
@@ -40,10 +40,12 @@ fi
 echo "Updating working copy"
 git fetch --all --prune --tags --force -j$(nproc)
 
+SOURCE_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
+source "${SOURCE_DIR}/git-vars.sh"
 branch=apache-arrow-${version}
 echo "Creating branch: ${branch}"
 git branch -D ${branch} || :
-git checkout -b ${branch} origin/master
+git checkout -b ${branch} origin/${DEFAULT_BRANCH}

Review comment:
       We should not change this because the repository is a fork of Homebrew/homebrew-core not apache/arrow.
   

##########
File path: dev/release/git-vars.sh
##########
@@ -0,0 +1,20 @@
+#!/usr/bin/env bash
+#

Review comment:
       Could you remove shebang because this is not executed?
   
   ```suggestion
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org