You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/07/27 14:47:34 UTC

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1377: MINIFICPP-1865 Integrate performance clang-tidy checks in CI

lordgamez commented on code in PR #1377:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1377#discussion_r931158517


##########
extensions/http-curl/tests/unit/InvokeHTTPTests.cpp:
##########
@@ -238,14 +238,14 @@ TEST_CASE("HTTPTestsPostNoResourceClaim", "[httptest1]") {
   auto records = plan->getProvenanceRecords();
   std::shared_ptr<core::FlowFile> record = plan->getCurrentFlowFile();
   REQUIRE(record == nullptr);
-  REQUIRE(records.size() == 0);
+  REQUIRE(records.empty());

Review Comment:
   I don't think we really care about the number of events in this test. The real question here is that if got any events or not. So if we break it and get any events here the count doesn't really help with the debugging IMO.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org