You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ri...@apache.org on 2023/01/05 18:44:54 UTC
[pinot] 02/02: print explain plan for successful verifications to compare against
This is an automated email from the ASF dual-hosted git repository.
richardstartin pushed a commit to branch debug-compatibility-verifier
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit 315381ec483682ad8ab2e63bd3328045e9692d59
Author: Richard Startin <ri...@apache.org>
AuthorDate: Thu Jan 5 18:44:24 2023 +0000
print explain plan for successful verifications to compare against
---
.../src/main/java/org/apache/pinot/compat/QueryOp.java | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/pinot-compatibility-verifier/src/main/java/org/apache/pinot/compat/QueryOp.java b/pinot-compatibility-verifier/src/main/java/org/apache/pinot/compat/QueryOp.java
index 0891194b93..a34a78ac14 100644
--- a/pinot-compatibility-verifier/src/main/java/org/apache/pinot/compat/QueryOp.java
+++ b/pinot-compatibility-verifier/src/main/java/org/apache/pinot/compat/QueryOp.java
@@ -139,13 +139,14 @@ public class QueryOp extends BaseOp {
boolean passed = SqlResultComparator.areEqual(actualJson, expectedJson, query);
if (passed) {
succeededQueryCount++;
- LOGGER.debug("Comparison PASSED: Line: {}, query: '{}', actual response: {}, expected response: {}",
- queryLineNum, query, actualJson, expectedJson);
+ LOGGER.debug(
+ "Comparison PASSED: Line: {}, query: '{}', actual response: {}, expected response: {}, explain "
+ + "plan: {}",
+ queryLineNum, query, actualJson, expectedJson, getExplainPlan(query));
} else {
LOGGER.error(
"Comparison FAILED: Line: {}, query: '{}', actual response: {}, expected response: {}, explain "
- + "plan: {}",
- queryLineNum, query, actualJson, expectedJson, getExplainPlan(query));
+ + "plan: {}", queryLineNum, query, actualJson, expectedJson, getExplainPlan(query));
}
} catch (Exception e) {
LOGGER.error(
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org