[GitHub] mistercrunch commented on a change in pull request #5122: Bump FAB and a bunch of JS libs

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #5122: Bump FAB and a bunch of JS libs
URL: https://github.com/apache/incubator-superset/pull/5122#discussion_r194571227
 
 

 ##########
 File path: superset/assets/package.json
 ##########
 @@ -150,13 +152,15 @@
     "react-addons-test-utils": "^15.6.2",
     "react-test-renderer": "^15.6.2",
     "redux-mock-store": "^1.2.3",
-    "sinon": "^4.0.0",
-    "style-loader": "^0.18.2",
+    "//": "known minor issues in >5.0",
 
 Review comment:
   Got this as a suggested way to squeeze comments into JSON:
   https://stackoverflow.com/questions/14221579/how-do-i-add-comments-to-package-json-for-npm-install
   
   This works with `yarn` but not the current version `npm`. I'm pretty sure npm used to allow this but not 100%. On Slack I mentioned to @GabeLoins that this may be a good way to force people to use `yarn` as a result, since we now use `yarn.lock`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org