You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/12/18 16:52:45 UTC

[GitHub] [hudi] nsivabalan commented on a change in pull request #4372: [HUDI-3064] Fixing a bug in FileSystemTestLock

nsivabalan commented on a change in pull request #4372:
URL: https://github.com/apache/hudi/pull/4372#discussion_r771843843



##########
File path: hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/transaction/FileSystemBasedLockProviderTestClass.java
##########
@@ -76,7 +76,7 @@ public boolean tryLock(long time, TimeUnit unit) {
     try {
       int numRetries = 0;
       while (fs.exists(new Path(lockPath + "/" + LOCK_NAME))
-          && (numRetries <= lockConfiguration.getConfig().getInteger(LOCK_ACQUIRE_NUM_RETRIES_PROP_KEY))) {
+          && (numRetries++ <= lockConfiguration.getConfig().getInteger(LOCK_ACQUIRE_NUM_RETRIES_PROP_KEY))) {

Review comment:
       sure. i will let you fix the actual test. but this fix seems inevitable for now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org