You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/02 18:31:52 UTC

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #17808: [WIP] Windows dev environment configuration, update install instructions from source in the docs

leezu commented on a change in pull request #17808: [WIP] Windows dev environment configuration, update install instructions from source in the docs
URL: https://github.com/apache/incubator-mxnet/pull/17808#discussion_r402526485
 
 

 ##########
 File path: CMakeLists.txt
 ##########
 @@ -163,6 +163,8 @@ if(MSVC)
   add_definitions(-DDMLC_STRICT_CXX11)
   add_definitions(-DNOMINMAX)
   set(CMAKE_C_FLAGS "/MP")
+  # report an accurate value for recent C++ language standards support
+  set(CMAKE_CXX_FLAGS "/Zc:__cplusplus")
 
 Review comment:
   @ChaiBapchya @vexilligera you added this line, but it doesn't have any effect as it is overwritte in the line below

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services