You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yongzhi Chen (Code Review)" <ge...@cloudera.org> on 2019/06/26 13:50:44 UTC
[Impala-ASF-CR] IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Yongzhi Chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13736
Change subject: IMPALA-8681: Only show ValidWriteIdLists for Acid tables
......................................................................
IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Lists ValidWriteIds for transactional tables in profile.
If a query does not trigger any transactional table loading,
the query profile will not have the "Loaded ValidWriteIdLists"
timeline.
Tests:
Manual tests.
Fixed StmtMetadataLoaderTest.
Sample output:
Query Compilation: 3s525ms
- Metadata load started: 37.369ms (37.369ms)
- Metadata load finished. loaded-tables=1/1 ...
- Loaded ValidWriteIdLists for transactional tables:
functional.insert_only_transactional_table:0:9223372036854775807::
: 3s312ms (551.463us)
- Analysis finished: 3s370ms (58.110ms)
...
Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905
---
M fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java
M fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java
2 files changed, 13 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/13736/1
--
To view, visit http://gerrit.cloudera.org:8080/13736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905
Gerrit-Change-Number: 13736
Gerrit-PatchSet: 1
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
[Impala-ASF-CR] IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13736 )
Change subject: IMPALA-8681: Only show ValidWriteIdLists for Acid tables
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3752/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905
Gerrit-Change-Number: 13736
Gerrit-PatchSet: 1
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 14:31:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13736 )
Change subject: IMPALA-8681: Only show ValidWriteIdLists for Acid tables
......................................................................
Patch Set 4: Code-Review+2
Thanks for the changes!
--
To view, visit http://gerrit.cloudera.org:8080/13736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905
Gerrit-Change-Number: 13736
Gerrit-PatchSet: 4
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Jul 2019 14:47:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13736 )
Change subject: IMPALA-8681: Only show ValidWriteIdLists for Acid tables
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4578/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905
Gerrit-Change-Number: 13736
Gerrit-PatchSet: 4
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Jul 2019 15:01:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13736 )
Change subject: IMPALA-8681: Only show ValidWriteIdLists for Acid tables
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905
Gerrit-Change-Number: 13736
Gerrit-PatchSet: 4
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Jul 2019 20:46:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13736 )
Change subject: IMPALA-8681: Only show ValidWriteIdLists for Acid tables
......................................................................
IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Lists ValidWriteIds for transactional tables in profile.
If a query does not trigger any transactional table loading,
the query profile will not have the "Loaded ValidWriteIdLists"
timeline.
Tests:
Manual tests.
Fixed StmtMetadataLoaderTest.
Added acid_profile test
Sample output:
Query Compilation: 3s525ms
- Metadata load started: 37.369ms (37.369ms)
- Metadata load finished. loaded-tables=1/1 ...
- Loaded ValidWriteIdLists for transactional tables:
functional.insert_only_transactional_table:0:9223372036854775807::
: 3s312ms (551.463us)
- Analysis finished: 3s370ms (58.110ms)
...
Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905
Reviewed-on: http://gerrit.cloudera.org:8080/13736
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java
M fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java
A testdata/workloads/functional-query/queries/QueryTest/acid-profile.test
M tests/common/skip.py
M tests/query_test/test_acid.py
5 files changed, 46 insertions(+), 10 deletions(-)
Approvals:
Csaba Ringhofer: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905
Gerrit-Change-Number: 13736
Gerrit-PatchSet: 5
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Posted by "Yongzhi Chen (Code Review)" <ge...@cloudera.org>.
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13736 )
Change subject: IMPALA-8681: Only show ValidWriteIdLists for Acid tables
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13736/2/testdata/workloads/functional-query/queries/QueryTest/acid-profile.test
File testdata/workloads/functional-query/queries/QueryTest/acid-profile.test:
http://gerrit.cloudera.org:8080/#/c/13736/2/testdata/workloads/functional-query/queries/QueryTest/acid-profile.test@16
PS2, Line 16: # Verify that ValidWriteIdLists in the profile
> nit: missing "is"
I will change
http://gerrit.cloudera.org:8080/#/c/13736/2/tests/query_test/test_acid.py
File tests/query_test/test_acid.py:
http://gerrit.cloudera.org:8080/#/c/13736/2/tests/query_test/test_acid.py@55
PS2, Line 55: @SkipIfCatalogV2.hms_event_polling_enabled()
> Can you explain why this is needed? Other acid tests also use the "create i
When local catalogV2 combines with hms_enent_polling enabled, it seems catalog loading the table by itself, the query statement cannot trigger loading the table(not sure it is by design or a bug). Because of the WriteIdlist profile is part of table loading, it can not be shown. This skip to avoid flaky tests.
--
To view, visit http://gerrit.cloudera.org:8080/13736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905
Gerrit-Change-Number: 13736
Gerrit-PatchSet: 2
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Jun 2019 19:59:40 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13736 )
Change subject: IMPALA-8681: Only show ValidWriteIdLists for Acid tables
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13736/2/tests/query_test/test_acid.py
File tests/query_test/test_acid.py:
http://gerrit.cloudera.org:8080/#/c/13736/2/tests/query_test/test_acid.py@55
PS2, Line 55: @SkipIfCatalogV2.hms_event_polling_enabled()
> When local catalogV2 combines with hms_enent_polling enabled, it seems cata
Can you add this information in a comment?
--
To view, visit http://gerrit.cloudera.org:8080/13736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905
Gerrit-Change-Number: 13736
Gerrit-PatchSet: 2
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Jul 2019 13:09:48 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13736 )
Change subject: IMPALA-8681: Only show ValidWriteIdLists for Acid tables
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13736/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13736/1//COMMIT_MSG@16
PS1, Line 16: Fixed StmtMetadataLoaderTest.
Maybe you coud add Hive3-only e2e tests with RUNTIME_PROFILE section that has "row_regex" check, like e.g. in QueryTest/spilling-aggs.test.
--
To view, visit http://gerrit.cloudera.org:8080/13736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905
Gerrit-Change-Number: 13736
Gerrit-PatchSet: 1
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 14:55:42 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13736 )
Change subject: IMPALA-8681: Only show ValidWriteIdLists for Acid tables
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3817/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905
Gerrit-Change-Number: 13736
Gerrit-PatchSet: 4
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Jul 2019 15:13:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Posted by "Yongzhi Chen (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Todd Lipcon, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13736
to look at the new patch set (#4).
Change subject: IMPALA-8681: Only show ValidWriteIdLists for Acid tables
......................................................................
IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Lists ValidWriteIds for transactional tables in profile.
If a query does not trigger any transactional table loading,
the query profile will not have the "Loaded ValidWriteIdLists"
timeline.
Tests:
Manual tests.
Fixed StmtMetadataLoaderTest.
Added acid_profile test
Sample output:
Query Compilation: 3s525ms
- Metadata load started: 37.369ms (37.369ms)
- Metadata load finished. loaded-tables=1/1 ...
- Loaded ValidWriteIdLists for transactional tables:
functional.insert_only_transactional_table:0:9223372036854775807::
: 3s312ms (551.463us)
- Analysis finished: 3s370ms (58.110ms)
...
Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905
---
M fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java
M fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java
A testdata/workloads/functional-query/queries/QueryTest/acid-profile.test
M tests/common/skip.py
M tests/query_test/test_acid.py
5 files changed, 46 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/13736/4
--
To view, visit http://gerrit.cloudera.org:8080/13736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905
Gerrit-Change-Number: 13736
Gerrit-PatchSet: 4
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Posted by "Yongzhi Chen (Code Review)" <ge...@cloudera.org>.
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13736 )
Change subject: IMPALA-8681: Only show ValidWriteIdLists for Acid tables
......................................................................
Patch Set 4:
(1 comment)
The comment for skipping is added.
http://gerrit.cloudera.org:8080/#/c/13736/2/tests/query_test/test_acid.py
File tests/query_test/test_acid.py:
http://gerrit.cloudera.org:8080/#/c/13736/2/tests/query_test/test_acid.py@55
PS2, Line 55: # that Catalog loads tables by itself, the q
> Can you add this information in a comment?
Done
--
To view, visit http://gerrit.cloudera.org:8080/13736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905
Gerrit-Change-Number: 13736
Gerrit-PatchSet: 4
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Jul 2019 14:34:31 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Posted by "Yongzhi Chen (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Todd Lipcon, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13736
to look at the new patch set (#3).
Change subject: IMPALA-8681: Only show ValidWriteIdLists for Acid tables
......................................................................
IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Lists ValidWriteIds for transactional tables in profile.
If a query does not trigger any transactional table loading,
the query profile will not have the "Loaded ValidWriteIdLists"
timeline.
Tests:
Manual tests.
Fixed StmtMetadataLoaderTest.
Added acid_profile test
Sample output:
Query Compilation: 3s525ms
- Metadata load started: 37.369ms (37.369ms)
- Metadata load finished. loaded-tables=1/1 ...
- Loaded ValidWriteIdLists for transactional tables:
functional.insert_only_transactional_table:0:9223372036854775807::
: 3s312ms (551.463us)
- Analysis finished: 3s370ms (58.110ms)
...
Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905
---
M fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java
M fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java
A testdata/workloads/functional-query/queries/QueryTest/acid-profile.test
M tests/common/skip.py
M tests/query_test/test_acid.py
5 files changed, 42 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/13736/3
--
To view, visit http://gerrit.cloudera.org:8080/13736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905
Gerrit-Change-Number: 13736
Gerrit-PatchSet: 3
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Posted by "Yongzhi Chen (Code Review)" <ge...@cloudera.org>.
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13736 )
Change subject: IMPALA-8681: Only show ValidWriteIdLists for Acid tables
......................................................................
Patch Set 3:
(1 comment)
patch 3 addresses the comment issue.
http://gerrit.cloudera.org:8080/#/c/13736/2/testdata/workloads/functional-query/queries/QueryTest/acid-profile.test
File testdata/workloads/functional-query/queries/QueryTest/acid-profile.test:
http://gerrit.cloudera.org:8080/#/c/13736/2/testdata/workloads/functional-query/queries/QueryTest/acid-profile.test@16
PS2, Line 16: # Verify that ValidWriteIdLists is in the profile
> I will change
Done
--
To view, visit http://gerrit.cloudera.org:8080/13736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905
Gerrit-Change-Number: 13736
Gerrit-PatchSet: 3
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Jun 2019 21:54:05 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Posted by "Yongzhi Chen (Code Review)" <ge...@cloudera.org>.
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13736 )
Change subject: IMPALA-8681: Only show ValidWriteIdLists for Acid tables
......................................................................
Patch Set 2:
(1 comment)
Add a new test with patch2
http://gerrit.cloudera.org:8080/#/c/13736/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13736/1//COMMIT_MSG@16
PS1, Line 16: Fixed StmtMetadataLoaderTest.
> Maybe you coud add Hive3-only e2e tests with RUNTIME_PROFILE section that h
Done
--
To view, visit http://gerrit.cloudera.org:8080/13736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905
Gerrit-Change-Number: 13736
Gerrit-PatchSet: 2
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Jun 2019 02:38:51 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Posted by "Yongzhi Chen (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Todd Lipcon, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13736
to look at the new patch set (#2).
Change subject: IMPALA-8681: Only show ValidWriteIdLists for Acid tables
......................................................................
IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Lists ValidWriteIds for transactional tables in profile.
If a query does not trigger any transactional table loading,
the query profile will not have the "Loaded ValidWriteIdLists"
timeline.
Tests:
Manual tests.
Fixed StmtMetadataLoaderTest.
Added acid_profile test
Sample output:
Query Compilation: 3s525ms
- Metadata load started: 37.369ms (37.369ms)
- Metadata load finished. loaded-tables=1/1 ...
- Loaded ValidWriteIdLists for transactional tables:
functional.insert_only_transactional_table:0:9223372036854775807::
: 3s312ms (551.463us)
- Analysis finished: 3s370ms (58.110ms)
...
Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905
---
M fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java
M fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java
A testdata/workloads/functional-query/queries/QueryTest/acid-profile.test
M tests/common/skip.py
M tests/query_test/test_acid.py
5 files changed, 42 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/13736/2
--
To view, visit http://gerrit.cloudera.org:8080/13736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905
Gerrit-Change-Number: 13736
Gerrit-PatchSet: 2
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13736 )
Change subject: IMPALA-8681: Only show ValidWriteIdLists for Acid tables
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3763/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905
Gerrit-Change-Number: 13736
Gerrit-PatchSet: 2
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Jun 2019 03:20:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13736 )
Change subject: IMPALA-8681: Only show ValidWriteIdLists for Acid tables
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3784/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905
Gerrit-Change-Number: 13736
Gerrit-PatchSet: 3
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Jun 2019 22:18:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8681: Only show ValidWriteIdLists for Acid tables
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13736 )
Change subject: IMPALA-8681: Only show ValidWriteIdLists for Acid tables
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13736/2/testdata/workloads/functional-query/queries/QueryTest/acid-profile.test
File testdata/workloads/functional-query/queries/QueryTest/acid-profile.test:
http://gerrit.cloudera.org:8080/#/c/13736/2/testdata/workloads/functional-query/queries/QueryTest/acid-profile.test@16
PS2, Line 16: # Verify that ValidWriteIdLists in the profile
nit: missing "is"
http://gerrit.cloudera.org:8080/#/c/13736/2/tests/query_test/test_acid.py
File tests/query_test/test_acid.py:
http://gerrit.cloudera.org:8080/#/c/13736/2/tests/query_test/test_acid.py@55
PS2, Line 55: @SkipIfCatalogV2.hms_event_polling_enabled()
Can you explain why this is needed? Other acid tests also use the "create in Hive, then invalidate and select in Impala" pattern.
--
To view, visit http://gerrit.cloudera.org:8080/13736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcc31c7ddcfc471b0e5308f7e4aaadfa8189a905
Gerrit-Change-Number: 13736
Gerrit-PatchSet: 2
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Jun 2019 16:11:49 +0000
Gerrit-HasComments: Yes