You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/10/05 14:37:48 UTC

[GitHub] [qpid-proton] jiridanek opened a new pull request #272: PROTON-2171: Add BUILD_EXAMPLES option, to optionally skip building examples

jiridanek opened a new pull request #272:
URL: https://github.com/apache/qpid-proton/pull/272


   This seems to be working, but I'll want to test it more, if I forgot anything. It was suspiciously easy to accomplish.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] [qpid-proton] astitcher commented on pull request #272: PROTON-2171: Add BUILD_EXAMPLES option, to optionally skip building examples

Posted by GitBox <gi...@apache.org>.
astitcher commented on pull request #272:
URL: https://github.com/apache/qpid-proton/pull/272#issuecomment-703793739


   I'm not surprised it's easy ,but what do you want to achieve it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] [qpid-proton] jiridanek merged pull request #272: PROTON-2171: Add BUILD_EXAMPLES option, to optionally skip building examples

Posted by GitBox <gi...@apache.org>.
jiridanek merged pull request #272:
URL: https://github.com/apache/qpid-proton/pull/272


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] [qpid-proton] jiridanek commented on pull request #272: PROTON-2171: Add BUILD_EXAMPLES option, to optionally skip building examples

Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #272:
URL: https://github.com/apache/qpid-proton/pull/272#issuecomment-703796354


   I am surprised. I had bad experience with CMake before.
   
   I want to fix PROTON-2171. The reason for the request is that building examples takes quite a lot of time, especially the C++ examples. Disabling everything that doesn't necessarily need to be built shortens compilation time needed, to get the libs.
   
   This option IMO makes sense for Dispatch CI, for example. It could save a few seconds of the compilation time.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] [qpid-proton] jiridanek merged pull request #272: PROTON-2171: Add BUILD_EXAMPLES option, to optionally skip building examples

Posted by GitBox <gi...@apache.org>.
jiridanek merged pull request #272:
URL: https://github.com/apache/qpid-proton/pull/272


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] [qpid-proton] astitcher edited a comment on pull request #272: PROTON-2171: Add BUILD_EXAMPLES option, to optionally skip building examples

Posted by GitBox <gi...@apache.org>.
astitcher edited a comment on pull request #272:
URL: https://github.com/apache/qpid-proton/pull/272#issuecomment-703793739


   This looks correct - I'm not surprised it's easy, but why do you want to achieve it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org