You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Anshul Gangwar <an...@citrix.com> on 2014/04/01 13:20:32 UTC
Review Request 19868: CLOUDSTACK-6287,
CLOUDSTACK-6315 fixed password visible in plain text during some operation
in hyperv
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19868/
-----------------------------------------------------------
Review request for cloudstack, Devdeep Singh and Rajesh Battala.
Bugs: CLOUDSTACK-6287 and CLOUDSTACK-6315
https://issues.apache.org/jira/browse/CLOUDSTACK-6287
https://issues.apache.org/jira/browse/CLOUDSTACK-6315
Repository: cloudstack-git
Description
-------
CLOUDSTACK-6287, CLOUDSTACK-6315 fixed password visible in plain text during some operation in hyperv
Diffs
-----
utils/src/com/cloud/utils/StringUtils.java 1600488
Diff: https://reviews.apache.org/r/19868/diff/
Testing
-------
verified by looking into logs whether password is logged for the commands mentioned in bugs
Thanks,
Anshul Gangwar
Re: Review Request 19868: CLOUDSTACK-6287,
CLOUDSTACK-6315 fixed password visible in plain text during some operation
in hyperv
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19868/#review40869
-----------------------------------------------------------
Commit 57f3e21317ee77befcb7af7d2c6cf5f1c0eacffa in cloudstack's branch refs/heads/master from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=57f3e21 ]
CLOUDSTACK-6287, CLOUDSTACK-6315 : fixed password visible in plain text in some hyperv request params/json response
- ASF Subversion and Git Services
On April 15, 2014, 4:45 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19868/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 4:45 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6287 and CLOUDSTACK-6315
> https://issues.apache.org/jira/browse/CLOUDSTACK-6287
> https://issues.apache.org/jira/browse/CLOUDSTACK-6315
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6287, CLOUDSTACK-6315 fixed password visible in plain text during some operation in hyperv
>
>
> Diffs
> -----
>
> utils/src/com/cloud/utils/StringUtils.java 1600488
>
> Diff: https://reviews.apache.org/r/19868/diff/
>
>
> Testing
> -------
>
> verified by looking into logs whether password is logged for the commands mentioned in bugs
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 19868: CLOUDSTACK-6287,
CLOUDSTACK-6315 fixed password visible in plain text during some operation
in hyperv
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19868/#review40757
-----------------------------------------------------------
Commit 4c4134721dde68f288b9ba273181c5db5fbbc41f in cloudstack's branch refs/heads/4.4 from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4c41347 ]
CLOUDSTACK-6287, CLOUDSTACK-6315 : fixed password visible in plain text in some hyperv request params/json response
- ASF Subversion and Git Services
On April 15, 2014, 4:45 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19868/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 4:45 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6287 and CLOUDSTACK-6315
> https://issues.apache.org/jira/browse/CLOUDSTACK-6287
> https://issues.apache.org/jira/browse/CLOUDSTACK-6315
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6287, CLOUDSTACK-6315 fixed password visible in plain text during some operation in hyperv
>
>
> Diffs
> -----
>
> utils/src/com/cloud/utils/StringUtils.java 1600488
>
> Diff: https://reviews.apache.org/r/19868/diff/
>
>
> Testing
> -------
>
> verified by looking into logs whether password is logged for the commands mentioned in bugs
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 19868: CLOUDSTACK-6287,
CLOUDSTACK-6315 fixed password visible in plain text during some operation
in hyperv
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19868/#review40756
-----------------------------------------------------------
Commit 4c4134721dde68f288b9ba273181c5db5fbbc41f in cloudstack's branch refs/heads/4.4 from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4c41347 ]
CLOUDSTACK-6287, CLOUDSTACK-6315 : fixed password visible in plain text in some hyperv request params/json response
- ASF Subversion and Git Services
On April 15, 2014, 4:45 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19868/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 4:45 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6287 and CLOUDSTACK-6315
> https://issues.apache.org/jira/browse/CLOUDSTACK-6287
> https://issues.apache.org/jira/browse/CLOUDSTACK-6315
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6287, CLOUDSTACK-6315 fixed password visible in plain text during some operation in hyperv
>
>
> Diffs
> -----
>
> utils/src/com/cloud/utils/StringUtils.java 1600488
>
> Diff: https://reviews.apache.org/r/19868/diff/
>
>
> Testing
> -------
>
> verified by looking into logs whether password is logged for the commands mentioned in bugs
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 19868: CLOUDSTACK-6287,
CLOUDSTACK-6315 fixed password visible in plain text during some operation
in hyperv
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19868/#review40871
-----------------------------------------------------------
Ship it!
Ship It!
- Devdeep Singh
On April 15, 2014, 4:45 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19868/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 4:45 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6287 and CLOUDSTACK-6315
> https://issues.apache.org/jira/browse/CLOUDSTACK-6287
> https://issues.apache.org/jira/browse/CLOUDSTACK-6315
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6287, CLOUDSTACK-6315 fixed password visible in plain text during some operation in hyperv
>
>
> Diffs
> -----
>
> utils/src/com/cloud/utils/StringUtils.java 1600488
>
> Diff: https://reviews.apache.org/r/19868/diff/
>
>
> Testing
> -------
>
> verified by looking into logs whether password is logged for the commands mentioned in bugs
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 19868: CLOUDSTACK-6287,
CLOUDSTACK-6315 fixed password visible in plain text during some operation
in hyperv
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19868/#review40868
-----------------------------------------------------------
Commit 57f3e21317ee77befcb7af7d2c6cf5f1c0eacffa in cloudstack's branch refs/heads/master from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=57f3e21 ]
CLOUDSTACK-6287, CLOUDSTACK-6315 : fixed password visible in plain text in some hyperv request params/json response
- ASF Subversion and Git Services
On April 15, 2014, 4:45 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19868/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 4:45 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6287 and CLOUDSTACK-6315
> https://issues.apache.org/jira/browse/CLOUDSTACK-6287
> https://issues.apache.org/jira/browse/CLOUDSTACK-6315
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6287, CLOUDSTACK-6315 fixed password visible in plain text during some operation in hyperv
>
>
> Diffs
> -----
>
> utils/src/com/cloud/utils/StringUtils.java 1600488
>
> Diff: https://reviews.apache.org/r/19868/diff/
>
>
> Testing
> -------
>
> verified by looking into logs whether password is logged for the commands mentioned in bugs
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 19868: CLOUDSTACK-6287,
CLOUDSTACK-6315 fixed password visible in plain text during some operation
in hyperv
Posted by Anshul Gangwar <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19868/
-----------------------------------------------------------
(Updated April 15, 2014, 4:45 a.m.)
Review request for cloudstack, Devdeep Singh and Rajesh Battala.
Changes
-------
now using regular expressions to find the password etc in details
Bugs: CLOUDSTACK-6287 and CLOUDSTACK-6315
https://issues.apache.org/jira/browse/CLOUDSTACK-6287
https://issues.apache.org/jira/browse/CLOUDSTACK-6315
Repository: cloudstack-git
Description
-------
CLOUDSTACK-6287, CLOUDSTACK-6315 fixed password visible in plain text during some operation in hyperv
Diffs (updated)
-----
utils/src/com/cloud/utils/StringUtils.java 1600488
Diff: https://reviews.apache.org/r/19868/diff/
Testing
-------
verified by looking into logs whether password is logged for the commands mentioned in bugs
Thanks,
Anshul Gangwar